Bug #5991

fiddle/conversion.c ignores unsigned qualifier

Added by Nobuyoshi Nakada about 3 years ago. Updated about 3 years ago.

[ruby-core:42458]
Status:Closed
Priority:Normal
Assignee:Aaron Patterson
ruby -v:r34519 Backport:

Description

=begin
In (({value_to_generic()})), ((|signed_p|)) seems to be ignored except for
(({TYPE_LONG})), and (({NUM2LONG()})) is used even if ((|signed_p|)) is not set.
(({NUM2INT()})) and (({NUM2UINT()})) have different value ranges, so I
think they should be separated.

And in (({generic_to_value()})), ((|signed_p|)) is ignored only for
(({TYPE_LONG_LONG})), and I can't see any reason to make the
difference.

Patch is attached.

fiddle.diff Magnifier (2.68 KB) Nobuyoshi Nakada, 02/10/2012 12:38 AM


Related issues

Duplicated by Backport193 - Backport #6022: DL on MinGW: bignum too big to convert into `long' (memor... Closed 02/15/2012

Associated revisions

Revision 34627
Added by Nobuyoshi Nakada about 3 years ago

  • ext/fiddle/closure.c (callback): deal with unsinged integers. [Bug #5991][Bug #6022]
  • ext/fiddle/conversions.c (value_to_generic, generic_to_value): ditto.

Revision 34627
Added by Nobuyoshi Nakada about 3 years ago

  • ext/fiddle/closure.c (callback): deal with unsinged integers. [Bug #5991][Bug #6022]
  • ext/fiddle/conversions.c (value_to_generic, generic_to_value): ditto.

History

#1 Updated by Nobuyoshi Nakada about 3 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r34627.
Nobuyoshi, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


  • ext/fiddle/closure.c (callback): deal with unsinged integers. [Bug #5991][Bug #6022]
  • ext/fiddle/conversions.c (value_to_generic, generic_to_value): ditto.

Also available in: Atom PDF