Backport #6220

Please backport r35167 and r35162

Added by Martin Bosslet about 2 years ago. Updated over 1 year ago.

[ruby-core:43832]
Status:Closed
Priority:Normal
Assignee:Martin Bosslet

noname (500 Bytes) Anonymous, 03/29/2012 12:53 PM

Associated revisions

Revision 35179
Added by Yui NARUSE about 2 years ago

merge revision(s) 35162,35167: [Backport #6220]

* test/openssl/test_x509cert.rb: Exclude test that fails when issuing
  a certificate with RSA signature and DSS1 digest for earlier
  OpenSSL versions when used in conjunction with OpenSSL 1.0.1.
  Thanks, Vit Ondruch, for reporting the issue.
  [Bug #6089]

* ext/openssl/ossl_pkcs7.c: fix crash when parsing garbage data.

* test/openssl/test_pkcs7.rb: assert correct behavior for it.
  Thanks to Matt Venables for reporting the issue.
  [Bug #6134]

* test/openssl/test_x509cert.rb: exclude test that fails when issuing

History

#1 Updated by Anonymous about 2 years ago

On Thu, Mar 29, 2012 at 10:34:01AM +0900, MartinBosslet (Martin Bosslet) wrote:

Issue #6220 has been reported by MartinBosslet (Martin Bosslet).


Backport #6220: Please backport r35167 and r35162
https://bugs.ruby-lang.org/issues/6220

Author: MartinBosslet (Martin Bosslet)
Status: Open
Priority: Normal
Assignee:
Category:
Target version:

http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=35167
http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=35162

Martin,

I think you can backport them yourself. Just assemble the patches and
submit them for review. Someone else on the ruby-core can +1 your
patch, and you can apply to the release branch yourself.

I can't remember the ruby-core thread where we decided to start doing
that (or I would reference it). The idea is to try to reduce the load
on the release manager! :-)

--
Aaron Patterson
http://tenderlovemaking.com/

#2 Updated by Martin Bosslet about 2 years ago

  • Status changed from Open to Assigned
  • Assignee set to Martin Bosslet

Martin,

I think you can backport them yourself. Just assemble the patches and
submit them for review. Someone else on the ruby-core can +1 your
patch, and you can apply to the release branch yourself.

I can't remember the ruby-core thread where we decided to start doing
that (or I would reference it). The idea is to try to reduce the load
on the release manager! :-)

--
Aaron Patterson
http://tenderlovemaking.com/

Oh yes, you're right! I was confused - I just wasn't supposed
to do backports myself in times of code freeze before a release. OK, sure,
didn't want to put a burden on anyone - I'll backport these myself!

#3 Updated by Yui NARUSE about 2 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r35179.
Martin, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


merge revision(s) 35162,35167: [Backport #6220]

* test/openssl/test_x509cert.rb: Exclude test that fails when issuing
  a certificate with RSA signature and DSS1 digest for earlier
  OpenSSL versions when used in conjunction with OpenSSL 1.0.1.
  Thanks, Vit Ondruch, for reporting the issue.
  [Bug #6089]

* ext/openssl/ossl_pkcs7.c: fix crash when parsing garbage data.

* test/openssl/test_pkcs7.rb: assert correct behavior for it.
  Thanks to Matt Venables for reporting the issue.
  [Bug #6134]

* test/openssl/test_x509cert.rb: exclude test that fails when issuing

#4 Updated by Martin Bosslet about 2 years ago

Oh, I just wanted to backport them - now I see you've done it already, thanks Yui!

Also available in: Atom PDF