Bug #6319: TestWEBrickHTTPRequest and WEBrick::TestFileHandler fail

• Status: Closed
• Assignee: naruse (Yui NARUSE)
• Target version: -
• ruby -v: ruby 2.0.0dev (2012-04-17 trunk 35368) [x86_64-linux]

[vo.x (Vit Ondruch)]

Hi, testing on Fedora Rawhide, I observe several test fails in TestWEBrickHTTPRequest and WEBrick::TestFileHandler. This seems to be the same errors as in #4110, however I am not sure it they are related.

4. Error:
   test_parse_09(TestWEBrickHTTPRequest):
   WEBrick::HTTPStatus::BadRequest: bad URI /'. /builddir/build/BUILD/ruby-2.0.0-r35368/lib/webrick/httprequest.rb:115:in rescue in parse'
   /builddir/build/BUILD/ruby-2.0.0-r35368/lib/webrick/httprequest.rb:104:in parse' /builddir/build/BUILD/ruby-2.0.0-r35368/lib/webrick/https.rb:30:in parse'
   /builddir/build/BUILD/ruby-2.0.0-r35368/test/webrick/test_httprequest.rb:21:in `test_parse_09'
5. Error:
   test_continue_sent(TestWEBrickHTTPRequest):
   WEBrick::HTTPStatus::BadRequest: bad URI /path'. /builddir/build/BUILD/ruby-2.0.0-r35368/lib/webrick/httprequest.rb:115:in rescue in parse'
   /builddir/build/BUILD/ruby-2.0.0-r35368/lib/webrick/httprequest.rb:104:in parse' /builddir/build/BUILD/ruby-2.0.0-r35368/lib/webrick/https.rb:30:in parse'
   /builddir/build/BUILD/ruby-2.0.0-r35368/test/webrick/test_httprequest.rb:347:in `test_continue_sent'
6. Error:
   test_continue_not_sent(TestWEBrickHTTPRequest):
   WEBrick::HTTPStatus::BadRequest: bad URI /path'. /builddir/build/BUILD/ruby-2.0.0-r35368/lib/webrick/httprequest.rb:115:in rescue in parse'
   /builddir/build/BUILD/ruby-2.0.0-r35368/lib/webrick/httprequest.rb:104:in parse' /builddir/build/BUILD/ruby-2.0.0-r35368/lib/webrick/https.rb:30:in parse'
   /builddir/build/BUILD/ruby-2.0.0-r35368/test/webrick/test_httprequest.rb:363:in `test_continue_not_sent'
7. Error:
   test_parse_10(TestWEBrickHTTPRequest):
   WEBrick::HTTPStatus::BadRequest: bad URI /'. /builddir/build/BUILD/ruby-2.0.0-r35368/lib/webrick/httprequest.rb:115:in rescue in parse'
   /builddir/build/BUILD/ruby-2.0.0-r35368/lib/webrick/httprequest.rb:104:in parse' /builddir/build/BUILD/ruby-2.0.0-r35368/lib/webrick/https.rb:30:in parse'
   /builddir/build/BUILD/ruby-2.0.0-r35368/test/webrick/test_httprequest.rb:38:in `test_parse_10'
8. Error:
   test_parse_11(TestWEBrickHTTPRequest):
   WEBrick::HTTPStatus::BadRequest: bad URI /path'. /builddir/build/BUILD/ruby-2.0.0-r35368/lib/webrick/httprequest.rb:115:in rescue in parse'
   /builddir/build/BUILD/ruby-2.0.0-r35368/lib/webrick/httprequest.rb:104:in parse' /builddir/build/BUILD/ruby-2.0.0-r35368/lib/webrick/https.rb:30:in parse'
   /builddir/build/BUILD/ruby-2.0.0-r35368/test/webrick/test_httprequest.rb:55:in `test_parse_11'
9. Error:
   test_parse_header2(TestWEBrickHTTPRequest):
   WEBrick::HTTPStatus::BadRequest: bad URI /foo/bar/../baz?q=a'. /builddir/build/BUILD/ruby-2.0.0-r35368/lib/webrick/httprequest.rb:115:in rescue in parse'
   /builddir/build/BUILD/ruby-2.0.0-r35368/lib/webrick/httprequest.rb:104:in parse' /builddir/build/BUILD/ruby-2.0.0-r35368/lib/webrick/https.rb:30:in parse'
   /builddir/build/BUILD/ruby-2.0.0-r35368/test/webrick/test_httprequest.rb:126:in `test_parse_header2'
10. Error:
    test_simple_request(TestWEBrickHTTPRequest):
    WEBrick::HTTPStatus::BadRequest: bad URI /'. /builddir/build/BUILD/ruby-2.0.0-r35368/lib/webrick/httprequest.rb:115:in rescue in parse'
    /builddir/build/BUILD/ruby-2.0.0-r35368/lib/webrick/httprequest.rb:104:in parse' /builddir/build/BUILD/ruby-2.0.0-r35368/lib/webrick/https.rb:30:in parse'
    /builddir/build/BUILD/ruby-2.0.0-r35368/test/webrick/test_httprequest.rb:11:in `test_simple_request'
11. Error:
    test_make_partial_content(WEBrick::TestFileHandler):
    WEBrick::HTTPStatus::BadRequest: bad URI /'. /builddir/build/BUILD/ruby-2.0.0-r35368/lib/webrick/httprequest.rb:115:in rescue in parse'
    /builddir/build/BUILD/ruby-2.0.0-r35368/lib/webrick/httprequest.rb:104:in parse' /builddir/build/BUILD/ruby-2.0.0-r35368/lib/webrick/https.rb:30:in parse'
    /builddir/build/BUILD/ruby-2.0.0-r35368/test/webrick/test_filehandler.rb:35:in make_range_response' /builddir/build/BUILD/ruby-2.0.0-r35368/test/webrick/test_filehandler.rb:47:in test_make_partial_content'

[mame (Yusuke Endoh)]

• Status changed from Open to Assigned
• Assignee set to naruse (Yui NARUSE)

I'm assigning this to naruse-san because he fixed #4110.

Vit, #4110 is a problem about hostname of a testing system; the tests failed if the hostname started with a number.
So, if this issue is really related, it may be helpful if you tell us the hostname of your system.

--
Yusuke Endoh [e-mail]

[naruse (Yui NARUSE)]

• Status changed from Assigned to Feedback

[vo.x (Vit Ondruch)]

This is my hostname:

hostname

dhcp-25-1.brq.redhat.com

[mame (Yusuke Endoh)]

• Status changed from Feedback to Assigned

Naruse-san, do you know what is wrong?

--
Yusuke Endoh [e-mail]

[naruse (Yui NARUSE)]

Could you printf debug with following patch?

diff --git a/lib/webrick/httprequest.rb b/lib/webrick/httprequest.rb
index 050b5ed..e60a7dd 100644
--- a/lib/webrick/httprequest.rb
+++ b/lib/webrick/httprequest.rb
@@ -112,7 +112,7 @@ module WEBrick
@script_name = ""
@path_info = @path.dup
rescue

•    raise HTTPStatus::BadRequest, "bad URI `#{@unparsed_uri}'."
  

•    raise HTTPStatus::BadRequest, "bad URI `#{@unparsed_uri}'.\n#{$!.inspect} #{$!.message}\n#{$!.backtrace[0,4].join("\n")}"
   end
  
   if /close/io =~ self["connection"]
  

[vo.x (Vit Ondruch)]

• Status changed from Assigned to Closed

Sorry, but I can't reproduce the error any more with ruby 2.0.0dev (2012-04-23 trunk 35432) [x86_64-linux]. I'm closing the issue.