Bug #6393

rdoc does not parse multibyte files

Added by Nobuyoshi Nakada almost 2 years ago. Updated over 1 year ago.

[ruby-core:44798]
Status:Closed
Priority:High
Assignee:Eric Hodel
Category:lib
Target version:2.0.0
ruby -v:r35518 Backport:

Description

=begin
(({RDoc::Parser.binary?})) mistakenly returns (({true})) against the
file which contains correct multibyte content.
The method reads 1024bytes in binary mode, but it may end in the
middle of a character and have incomplete byte sequence.
=end

0002-rdoc-non-binary-multibyte.patch Magnifier (1.19 KB) Nobuyoshi Nakada, 05/02/2012 03:47 PM

Associated revisions

Revision 35531
Added by Nobuyoshi Nakada almost 2 years ago

rdoc: non-binary multibyte

  • lib/rdoc/parser.rb (RDoc.binary?): binary read data may have incomplete multibyte sequence. [Bug #6393]

Revision 35534
Added by Yui NARUSE almost 2 years ago

  • lib/rdoc/parser.rb (RDoc.binary?): fix wrong regexp. [Bug #6393]

Revision 38690
Added by Eric Hodel over 1 year ago

  • lib/rdoc/cross_reference.rb: Fixed matching of C#=== or #===. RDoc bug #164
  • test/rdoc/testrdoccross_reference.rb: Test for above.

  • lib/rdoc/parser/changelog.rb: Fixed parsing of dates. RDoc bug #165

  • test/rdoc/testrdocparser_changelog.rb: Test for above.

  • lib/rdoc/parser.rb: Fixed parsing multibyte files with incomplete
    characters at byte 1024. [ruby-trunk - Bug #6393]
    Fixed handling of -E. [ruby-trunk - Bug #6392]

  • test/rdoc/testrdocoptions.rb: Test for above.

  • test/rdoc/testrdocparser.rb: ditto.

  • test/rdoc/testrdocparser_c.rb: ditto.

  • test/rdoc/testrdocparser_changelog.rb: ditto.

  • test/rdoc/testrdocparser_markdown.rb: ditto.

  • test/rdoc/testrdocparser_rd.rb: ditto.

  • test/rdoc/testrdocrdoc.rb: ditto.

  • lib/rdoc/tom_doc.rb: Fixed parsing of [] in TomDoc arguments list.
    RDoc bug #167

  • test/rdoc/testrdoctom_doc.rb: Test for above.

  • lib/rdoc.rb: Update version.

History

#1 Updated by Nobuyoshi Nakada almost 2 years ago

  • Status changed from Open to Assigned

#2 Updated by Nobuyoshi Nakada almost 2 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r35531.
Nobuyoshi, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


rdoc: non-binary multibyte

  • lib/rdoc/parser.rb (RDoc.binary?): binary read data may have incomplete multibyte sequence. [Bug #6393]

#3 Updated by Nobuyoshi Nakada over 1 year ago

  • Status changed from Closed to Assigned
  • Priority changed from Normal to High
  • % Done changed from 100 to 0

#4 Updated by Eric Hodel over 1 year ago

  • Status changed from Assigned to Closed

Thank you for the patch, I have checked it and it is good.

Also available in: Atom PDF