Backport #7120: [[Ruby 1.9:]] ${cflags} missing from CFLAGS

• Status: Closed
• Assignee: usa (Usaku NAKAMURA)

[mpapis (Michal Papis)]

=begin
Because ruby does not allow multiple --with-opt-dir= - so RVM uses CFLAGS=/LDFLAGS= to not block --with-opt-dir= from users.

This lead to an issue where ruby detected flags are not set if CFLAGS is provided earlier.

I did prepare a patch to persist the detected flags in CFLAGS: https://gist.github.com/3854178.

There is no way for user to detect the flags by himself, user would have to reproduce the whole ruby detection process to make it working.

The patch puts ${cflags} before the given CFLAGS, so users can still overwrite the auto-detected values as the last flag is relevant.

There is an initial report if more context is needed: https://github.com/wayneeseguin/rvm/issues/1203
=end

[nobu (Nobuyoshi Nakada)]

• Status changed from Open to Rejected

--with-opt-dir allows multiple paths separated by File::PATH_SEPARATOR.

[mpapis (Michal Papis)]

=begin
Then help for configure should be updated, in current state it indicates that it's just one path:

--with-opt-dir=DIR      add optional headers and libraries DIR

Also adding support for multiple --with-opt-dir= would be awesome, so it would be easy to put multiple dirs without parsing if --with-opt-dir= was already specified.
=end

[nobu (Nobuyoshi Nakada)]

• Status changed from Rejected to Open

[nobu (Nobuyoshi Nakada)]

• Status changed from Open to Closed
• % Done changed from 0 to 100

This issue was solved with changeset r37242.
Michal, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

---

configure.in: multiple opt-dir

• configure.in (opt-dir): allow multiple directories separated by
  $PATH_SEPARATOR as well as dir_config in mkmf.rb. [ruby-core:47868]
  [Bug #7120]

[mpapis (Michal Papis)]

Will this fix be merged back to 1.9.3 or should I rely on my patch when using CFLAGS / LDFLAGS?

[usa (Usaku NAKAMURA)]

• Status changed from Closed to Assigned
• Assignee set to usa (Usaku NAKAMURA)
• Target version set to 1.9.3

It'll be backported.

[usa (Usaku NAKAMURA)]

• Tracker changed from Bug to Backport
• Project changed from Ruby master to Backport193
• Target version deleted (1.9.3)

[usa (Usaku NAKAMURA)]

• Status changed from Assigned to Closed

This issue was solved with changeset r37266.
Michal, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

---

merge revision(s) 37242: [Backport #7120]

* configure.in (opt-dir): allow multiple directories separated by
  $PATH_SEPARATOR as well as dir_config in mkmf.rb. [ruby-core:47868]
  [Bug #7120]