Project

General

Profile

Bug #7281

Fix typo in macro name to actually enable rb_reserved_fd_p()

Added by Mark Somerville over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
ruby -v:
2.0.0-preview1
Backport:
2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN, 2.3: UNKNOWN
[ruby-core:48940]

Description

In trunk (r37474), there is a typo in a macro name in the rb_reserved_fd_p() function. This prevents any actual checking that the file descriptor is reserved by the VM.

sleepy_timer_thread_typo.patch Magnifier - A patch to fix the bug (855 Bytes) Mark Somerville, 11/06/2012 01:10 AM

Associated revisions

Revision 37483
Added by Motohiro KOSAKI over 3 years ago

  • thread_pthread.c (rb_reserved_fd_p): fix typo in macro check that prevented the ifdef ever being true. [Bug #7281]

Revision 37483
Added by Motohiro KOSAKI over 3 years ago

  • thread_pthread.c (rb_reserved_fd_p): fix typo in macro check that prevented the ifdef ever being true. [Bug #7281]

History

#1 Updated by Motohiro KOSAKI over 3 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r37483.
Mark, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


  • thread_pthread.c (rb_reserved_fd_p): fix typo in macro check that prevented the ifdef ever being true. [Bug #7281]

#2 [ruby-core:48942] Updated by Motohiro KOSAKI over 3 years ago

Thanks for digging!

Your patch was commited at r37483 as is.

Also available in: Atom PDF