Project

General

Profile

Actions
Copy link

Bug #7483

closed

Fiddle::Function::STDCALL is never defined even on WIN32

Added by ngoto (Naohisa Goto) over 11 years ago. Updated over 11 years ago.

Status:
Closed
Assignee:
tenderlovemaking (Aaron Patterson)
Target version:
-
ruby -v:
-
Backport:
[ruby-core:50398]

Description

In ext/fiddle/function.c, Fiddle::Function::STDCALL is defined only when "#ifdef FFI_STDCALL" is true. However, in ffi.h, FFI_STDCALL is declared as an enumerated type, not a macro, and it is always false even on x86 WIN32. According to the Changelog in libffi-3.0.11.tar.gz, FFI_STDCALL was first added in 2002-11-10 as an enumeration.

I create a patch to check existance of FFI_STDCALL in extconf.rb.

Files

fiddle-functions-stdcall.patch (855 Bytes) fiddle-functions-stdcall.patch ngoto (Naohisa Goto), 12/01/2012 12:44 AM
Actions
Copy link
 #1

Updated by ngoto (Naohisa Goto) over 11 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r38073.
Naohisa, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

  • ext/fiddle/extconf.rb, ext/fiddle/function.c
    (Fiddle::Function::STDCALL): FFI_STDCALL is not a macro, but an enumeration. [ruby-core:50398] [Bug #7483]
Actions
Copy link

Also available in: Atom PDF

Like0
Like0