Project

General

Profile

Bug #7483

Fiddle::Function::STDCALL is never defined even on WIN32

Added by ngoto (Naohisa Goto) over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
tenderlovemaking (Aaron Patterson)
Target version:
-
ruby -v:
-
Backport:
2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: UNKNOWN
[ruby-core:50398]

Description

In ext/fiddle/function.c, Fiddle::Function::STDCALL is defined only when "#ifdef FFI_STDCALL" is true. However, in ffi.h, FFI_STDCALL is declared as an enumerated type, not a macro, and it is always false even on x86 WIN32. According to the Changelog in libffi-3.0.11.tar.gz, FFI_STDCALL was first added in 2002-11-10 as an enumeration.

I create a patch to check existance of FFI_STDCALL in extconf.rb.

fiddle-functions-stdcall.patch (855 Bytes) fiddle-functions-stdcall.patch ngoto (Naohisa Goto), 12/01/2012 12:44 AM

Associated revisions

Revision 4bb1bfa0
Added by ngoto (Naohisa Goto) over 5 years ago

  • ext/fiddle/extconf.rb, ext/fiddle/function.c (Fiddle::Function::STDCALL): FFI_STDCALL is not a macro, but an enumeration. [Bug #7483]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@38073 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 38073
Added by ngoto (Naohisa Goto) over 5 years ago

  • ext/fiddle/extconf.rb, ext/fiddle/function.c (Fiddle::Function::STDCALL): FFI_STDCALL is not a macro, but an enumeration. [Bug #7483]

Revision 38073
Added by ngoto (Naohisa Goto) over 5 years ago

  • ext/fiddle/extconf.rb, ext/fiddle/function.c (Fiddle::Function::STDCALL): FFI_STDCALL is not a macro, but an enumeration. [Bug #7483]

Revision 38073
Added by ngoto (Naohisa Goto) over 5 years ago

  • ext/fiddle/extconf.rb, ext/fiddle/function.c (Fiddle::Function::STDCALL): FFI_STDCALL is not a macro, but an enumeration. [Bug #7483]

Revision 38073
Added by ngoto (Naohisa Goto) over 5 years ago

  • ext/fiddle/extconf.rb, ext/fiddle/function.c (Fiddle::Function::STDCALL): FFI_STDCALL is not a macro, but an enumeration. [Bug #7483]

Revision 38073
Added by ngoto (Naohisa Goto) over 5 years ago

  • ext/fiddle/extconf.rb, ext/fiddle/function.c (Fiddle::Function::STDCALL): FFI_STDCALL is not a macro, but an enumeration. [Bug #7483]

Revision 3912b7f2
Added by usa (Usaku NAKAMURA) over 5 years ago

merge revision(s) 38073,38251,38252: [Backport #7552]

* ext/fiddle/extconf.rb, ext/fiddle/function.c
  (Fiddle::Function::STDCALL): FFI_STDCALL is not a macro, but an
  enumeration.  [Bug #7483]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_9_3@38505 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

History

#1 Updated by ngoto (Naohisa Goto) over 5 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r38073.
Naohisa, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

  • ext/fiddle/extconf.rb, ext/fiddle/function.c (Fiddle::Function::STDCALL): FFI_STDCALL is not a macro, but an enumeration. [Bug #7483]

Also available in: Atom PDF