Project

General

Profile

Bug #7483

Fiddle::Function::STDCALL is never defined even on WIN32

Added by Naohisa Goto almost 4 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Aaron Patterson
ruby -v:
-
Backport:
2.1: UNKNOWN, 2.2: UNKNOWN, 2.3: UNKNOWN
[ruby-core:50398]

Description

In ext/fiddle/function.c, Fiddle::Function::STDCALL is defined only when "#ifdef FFI_STDCALL" is true. However, in ffi.h, FFI_STDCALL is declared as an enumerated type, not a macro, and it is always false even on x86 WIN32. According to the Changelog in libffi-3.0.11.tar.gz, FFI_STDCALL was first added in 2002-11-10 as an enumeration.

I create a patch to check existance of FFI_STDCALL in extconf.rb.

fiddle-functions-stdcall.patch View (855 Bytes) Naohisa Goto, 12/01/2012 12:44 AM

Associated revisions

Revision 38073
Added by Naohisa Goto almost 4 years ago

  • ext/fiddle/extconf.rb, ext/fiddle/function.c (Fiddle::Function::STDCALL): FFI_STDCALL is not a macro, but an enumeration. [Bug #7483]

Revision 38073
Added by Naohisa Goto almost 4 years ago

  • ext/fiddle/extconf.rb, ext/fiddle/function.c (Fiddle::Function::STDCALL): FFI_STDCALL is not a macro, but an enumeration. [Bug #7483]

Revision 38073
Added by Naohisa Goto almost 4 years ago

  • ext/fiddle/extconf.rb, ext/fiddle/function.c (Fiddle::Function::STDCALL): FFI_STDCALL is not a macro, but an enumeration. [Bug #7483]

History

#1 Updated by Naohisa Goto almost 4 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r38073.
Naohisa, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

  • ext/fiddle/extconf.rb, ext/fiddle/function.c (Fiddle::Function::STDCALL): FFI_STDCALL is not a macro, but an enumeration. [Bug #7483]

Also available in: Atom PDF