Project

General

Profile

Backport #7634

Documentation for class.c methods is missing

Added by zzak (Zachary Scott) over 6 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
[ruby-core:51181]

Description

This seems to have been fixed before in r36272, but went missing again.

See #6666 for original discussion.

I think this is the offending commit, but I cannot find revision: https://github.com/ruby/ruby/commit/e7996eb3cc1687d1f70ea8f78befddf821ad3ff0#diff-24


Files

36272.patch (1.28 KB) 36272.patch zzak (Zachary Scott), 01/12/2013 01:07 AM

Associated revisions

Revision 00decfdb
Added by usa (Usaku NAKAMURA) over 6 years ago

merge revision(s) 36272: [Backport #7634]

    * object.c (Init_Object):  Added RDoc location pointers for
      Kernel#methods, Kernel#protected_methods, Kernel#private_methods and
      Kernel#public_methods.  [Bug #6666]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_9_3@38826 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 38826
Added by usa (Usaku NAKAMURA) over 6 years ago

merge revision(s) 36272: [Backport #7634]

* object.c (Init_Object):  Added RDoc location pointers for
  Kernel#methods, Kernel#protected_methods, Kernel#private_methods and
  Kernel#public_methods.  [Bug #6666]

History

Updated by zzak (Zachary Scott) over 6 years ago

  • Status changed from Open to Assigned

Updated by charliesome (Charlie Somerville) over 6 years ago

=begin
If you look at the git-svn-id in the commit message:

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@32156 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

The bit after the @ sign is the revision number.

So in this case the offending commit is r32156
=end

Updated by zzak (Zachary Scott) over 6 years ago

TIL: thank you charlie!

Updated by usa (Usaku NAKAMURA) over 6 years ago

So, what should I do?
merging r36272?

Updated by zzak (Zachary Scott) over 6 years ago

I think so, I've attached the patch so you can apply it directly if that is easier.

Thanks Usaku-san!

#6

Updated by usa (Usaku NAKAMURA) over 6 years ago

  • % Done changed from 0 to 100
  • Status changed from Assigned to Closed

This issue was solved with changeset r38826.
Zachary, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


merge revision(s) 36272: [Backport #7634]

* object.c (Init_Object):  Added RDoc location pointers for
  Kernel#methods, Kernel#protected_methods, Kernel#private_methods and
  Kernel#public_methods.  [Bug #6666]

Also available in: Atom PDF