Bug #7902

The test suite does not honor configuration options

Added by Vit Ondruch about 1 year ago. Updated about 1 year ago.

[ruby-core:52623]
Status:Closed
Priority:Normal
Assignee:Nobuyoshi Nakada
Category:-
Target version:-
ruby -v:ruby 2.0.0dev (2013-02-21 trunk 39357) [x86_64-linux] Backport:

Description

=begin
Rev 39201 and 39201 introduced new test cases, which fails for me:

# make test-all TESTS="test/testrbconfig.rb"
CC = gcc
LD = ld
LDSHARED = gcc -shared
CFLAGS = -O2 -g -pipe -Wall -Wp,-D
FORTIFYSOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -mtune=generic -fPIC -m64
XCFLAGS = -include ruby/config.h -include ruby/missing.h -D
FORTIFYSOURCE=2 -fstack-protector -fno-strict-overflow -fvisibility=hidden -DRUBYEXPORT
CPPFLAGS = -I. -I.ext/include/x8664-linux -I./include -I.
DLDFLAGS = -Wl,-soname,libruby.so.2.0 -fstack-protector -m64
SOLIBS = -lpthread -lrt -ldl -lcrypt -lm

./miniruby -I./lib -I. -I.ext/common ./tool/runruby.rb --extout=.ext -- --disable-gems "./test/runner.rb" --ruby="./miniruby -I./lib -I. -I.ext/common ./tool/runruby.rb --extout=.ext -- --disable-gems" test/test
rbconfig.rb
Run options: "--ruby=./miniruby -I./lib -I. -I.ext/common ./tool/runruby.rb --extout=.ext -- --disable-gems"

# Running tests:

[2/5] TestRbConfig#testsitearchdirs = 0.00 s

1) Failure:
test
sitearchdirs(TestRbConfig) [/builddir/build/BUILD/ruby-2.0.0-r39357/test/testrbconfig.rb:30]:
sitearchdir [Bug #7823].
Expected /\$(sitearch|\$(rubysitearchprefix)/ to match "$(DESTDIR)/usr/local/lib64/ruby/site
ruby".

[4/5] TestRbConfig#testvendorarchdirs = 0.00 s

2) Failure:
test
vendorarchdirs(TestRbConfig) [/builddir/build/BUILD/ruby-2.0.0-r39357/test/testrbconfig.rb:38]:
vendorarchdir [Bug #7823].
Expected /\$(sitearch|\$(rubysitearchprefix)/ to match "$(DESTDIR)/usr/lib64/ruby/vendor
ruby".

Finished tests in 0.005311s, 941.3960 tests/s, 5271.8177 assertions/s.
5 tests, 28 assertions, 2 failures, 0 errors, 0 skips

ruby -v: ruby 2.0.0dev (2013-02-21 trunk 39357) [x86_64-linux]
make: *** [yes-test-all] Error 2

They obviously does not respect configuration options. Here is the configure command I used:

./configure --build=x8664-redhat-linux-gnu --host=x8664-redhat-linux-gnu --program-prefix= --disable-dependency-tracking --prefix=/usr --exec-prefix=/usr --bindir=/usr/bin --sbindir=/usr/sbin --sysconfdir=/etc --datadir=/usr/share --includedir=/usr/include --libdir=/usr/lib64 --libexecdir=/usr/libexec --localstatedir=/var --sharedstatedir=/var/lib --mandir=/usr/share/man --infodir=/usr/share/info --with-rubylibprefix=/usr/share/ruby --with-sitedir=/usr/local/share/ruby/siteruby --with-sitearchdir=/usr/local/lib64/ruby/siteruby --with-vendordir=/usr/share/ruby/vendorruby --with-vendorarchdir=/usr/lib64/ruby/vendorruby --with-rubyhdrdir=/usr/include --with-ruby-pc=ruby.pc --disable-rpath --enable-shared --with-ruby-version=''

I hope this can be fixed prior Ruby 2.0.0. Thank you.
=end

Associated revisions

Revision 39372
Added by Nobuyoshi Nakada about 1 year ago

test_rbconfig.rb: honor configuration options

  • test/test_rbconfig.rb (TestRbConfig): skip user defined values by configuration options. [Bug #7902]

History

#1 Updated by Nobuyoshi Nakada about 1 year ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r39372.
Vit, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


test_rbconfig.rb: honor configuration options

  • test/test_rbconfig.rb (TestRbConfig): skip user defined values by configuration options. [Bug #7902]

Also available in: Atom PDF