Backport #8069
closedUpdated by nagachika (Tomoyuki Chikanaga) about 11 years ago
Thank you Luis.
I'll backport it with r39701.
Updated by luislavena (Luis Lavena) about 11 years ago
Hello,
As pointed out by nobu, I was missing some tests.
The complete list of revisions to be backported are:
r39697
r39701
r39716
r39740
r39751
For simplicity I have attached a patch that includes both code and ChangeLog modifications for ruby_2_0_0 branch.
I was not able to test it due configure errors:
http://ci.rubyinstaller.org/job/ruby-2_0_0-x86-build/35/console
http://ci.rubyinstaller.org/job/ruby-2_0_0-x64-build/35/console
But a quick look to the code itself didn't show any potential problem.
Thank you.
Updated by nagachika (Tomoyuki Chikanaga) about 11 years ago
- Status changed from Assigned to Closed
- % Done changed from 0 to 100
This issue was solved with changeset r40249.
Luis, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
merge revision(s) 39697,39701,39716,39740,39751: [Backport #8069]
* win32/file.c (rb_file_expand_path_internal): Expand home directory when
used as second parameter (dir_string). [ruby-core:53168] [Bug #8034]
* test/ruby/test_file_exhaustive.rb: add test to verify.
* win32/file.c (get_user_from_path): add internal function that retrieves
username from supplied path (refactored).
* win32/file.c (rb_file_expand_path_internal): refactor expansion of user
home to use get_user_from_path and cover dir_string corner cases.
[ruby-core:53168] [Bug #8034]