Project

General

Profile

This project is closed and read-only.

Actions

Backport #8319

closed

Tk::Canvas.create raise if type TkcItem

Backport #8319: Tk::Canvas.create raise if type TkcItem

Added by zzak (zzak _) over 13 years ago. Updated about 13 years ago.

Status:
Closed
[ruby-core:54544]

Description

From ((<GitHub#295|URL:https://github.com/ruby/ruby/pull/295>))


Files

295.patch (3.5 KB) 295.patch zzak (zzak _), 04/24/2013 01:59 PM

Updated by windwiny (wind winy) over 13 years ago Actions #1 [ruby-core:54597]

@zzak (zzak _), @nagai (Hidetoshi Nagai),

This patch is fix sample bug

  1. ext/tk/sample/demos-en/floor2.rb and ext/tk/sample/demos-en/knightstour.rb , using Tk::Canvas.create .
  2. ext/tk/sample/demos-en/dialog1.rb , Tk.update run after eval_samplecode Dialog close may be throw nilClass.

Updated by nagai (Hidetoshi Nagai) about 13 years ago Actions #2

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r41347.
Zachary, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


  • ext/tk/extconf.rb: support s390x (Thanks to bkabrda) [ruby-trunk - Bug #5465]
  • ext/tk/extconf.rb: apply [Backport87 - Backport #5048]
  • ext/tk/lib/tk/canvas.rb, ext/tk/sample/demos-{en,jp}/{tree.rb,widget}: fix bug (Thanks to zzak) [ruby-trunk - Bug #8319]

Updated by nagachika (Tomoyuki Chikanaga) about 13 years ago Actions #3

  • Tracker changed from Bug to Backport
  • Project changed from Ruby to 15
  • Category deleted (ext)
  • Status changed from Closed to Assigned
  • Assignee changed from nagai (Hidetoshi Nagai) to nagachika (Tomoyuki Chikanaga)
  • Target version deleted (2.1.0)

Updated by nagachika (Tomoyuki Chikanaga) about 13 years ago Actions #4

  • Status changed from Assigned to Closed

This issue was solved with changeset r41362.
Zachary, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


merge revision(s) 41347: [Backport #5048] [Backport #5465] [Backport #8319]

* ext/tk/extconf.rb: support s390x (Thanks to bkabrda) [ruby-trunk - Bug #5465]
* ext/tk/extconf.rb: apply [Backport87 - Backport #5048]
* ext/tk/lib/tk/canvas.rb, ext/tk/sample/demos-{en,jp}/{tree.rb,widget}: fix bug (Thanks to zzak) [ruby-trunk - Bug #8319]

Updated by nagachika (Tomoyuki Chikanaga) about 13 years ago Actions #5

  • Project changed from 15 to 13
  • Status changed from Closed to Assigned
  • Assignee changed from nagachika (Tomoyuki Chikanaga) to usa (Usaku NAKAMURA)

related tickets: #5048 #5465

Updated by usa (Usaku NAKAMURA) about 13 years ago Actions #6

  • Status changed from Assigned to Closed

This issue was solved with changeset r41651.
Zachary, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


merge revision(s) 41347: [Backport #8319]

* ext/tk/extconf.rb: support s390x (Thanks to bkabrda) [ruby-trunk - Bug #5465]
* ext/tk/extconf.rb: apply [Backport87 - Backport #5048]
* ext/tk/lib/tk/canvas.rb, ext/tk/sample/demos-{en,jp}/{tree.rb,widget}: fix bug (Thanks to zzak) [ruby-trunk - Bug #8319]
Actions

Also available in: PDF Atom