Project

General

Profile

Actions

Feature #8343

closed

StringScanner#[] should accept names of named captures

Added by rkh (Konstantin Haase) almost 11 years ago. Updated almost 11 years ago.

Status:
Closed
Target version:
-
[ruby-core:54664]

Description

Example:

s = StringScanner.new("Fri Dec 12 1975 14:39")
s.scan(/(?<wday>\w+) (?<month>\w+) (?<day>\d+) /)

# this currently works
s[0]                               # -> "Fri Dec 12 "
s[1]                               # -> "Fri"
s[2]                               # -> "Dec"
s[3]                               # -> "12"

# this currently does not work
s[:wday]                           # -> "Fri"
s[:month]                          # -> "Dec"
s[:day]                            # -> "12"

I attached a patch including tests for MRI, I don't know if Rubinius has a different implementation, I guess JRuby has.
I can look into this if the feature gets accepted.


Files

Updated by rkh (Konstantin Haase) almost 11 years ago

On a related note: should the patch be submitted in a second issue on the ruby-trunk project?

Updated by naruse (Yui NARUSE) almost 11 years ago

  • Status changed from Open to Assigned
  • Assignee set to naruse (Yui NARUSE)

rkh (Konstantin Haase) wrote:

On a related note: should the patch be submitted in a second issue on the ruby-trunk project?

Here is also correct place now.
I'll merge this if there are no objection.

Actions #3

Updated by naruse (Yui NARUSE) almost 11 years ago

  • Status changed from Assigned to Closed
  • Project changed from 14 to Ruby master

Merged at r40881!

Actions

Also available in: Atom PDF

Like0
Like0Like0Like0