Project

General

Profile

Actions

Backport #8367

closed

regression in defined?(super) starting with 2.0.0-p0

Added by indirect (André Arko) over 11 years ago. Updated over 11 years ago.


Description

=begin
Hello,

I have discovered a regression in the behaviour of (({defined?(super)})). It functions as expected in 1.9.3-p392, but has changed in 2.0.0-p0 and in 2.1.0dev (2013-05-03 trunk 40571).

On Ruby 1.9.3, the call returns the string (({"super"})). On 2.0.0-p0 and above, the call returns (({nil})). The change seems to be specific to the inside of a block in a method that is defined in a module that is extended onto the object where the method is called.

This is a minimal reproduction example, which I have also attached as "super-gone.rb".

class C
def x; end
end

module M
def b; yield; end

def x
b do
# On 1.9.3, this is "super", but on 2.0.0 it is nil
p defined?(super)
end
end
end

c = C.new
c.extend M
c.x

Thank you.
=end


Files

super-gone.rb (491 Bytes) super-gone.rb indirect (André Arko), 05/04/2013 10:20 AM

Related issues 1 (0 open1 closed)

Related to Ruby master - Bug #6644: Weird behavior of defined?(super) check invoked from a metaprogrammatically defined class methodClosed06/25/2012Actions

Updated by nagachika (Tomoyuki Chikanaga) over 11 years ago

  • Category set to core
  • Status changed from Open to Assigned
  • Assignee set to nobu (Nobuyoshi Nakada)
  • Target version set to 2.1.0
  • Backport changed from 1.9.3: UNKNOWN, 2.0.0: UNKNOWN to 1.9.3: UNKNOWN, 2.0.0: REQUIRED
Actions #2

Updated by nobu (Nobuyoshi Nakada) over 11 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r40583.
André, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


insns.def: method entry from method frame

  • insns.def (defined): get method entry from the method top level
    frame, not block frame. [ruby-core:54769] [Bug #8367]
Actions #3

Updated by nobu (Nobuyoshi Nakada) over 11 years ago

  • Tracker changed from Bug to Backport
  • Project changed from Ruby master to Backport200
  • Category deleted (core)
  • Status changed from Closed to Assigned
  • Assignee changed from nobu (Nobuyoshi Nakada) to nagachika (Tomoyuki Chikanaga)
  • Target version deleted (2.1.0)

Updated by nagachika (Tomoyuki Chikanaga) over 11 years ago

Hello,

Should I backport r40584 too?

Updated by nobu (Nobuyoshi Nakada) over 11 years ago

Probably, yes.

Actions #6

Updated by nagachika (Tomoyuki Chikanaga) over 11 years ago

  • Status changed from Assigned to Closed

This issue was solved with changeset r40613.
André, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


merge revision(s) 40583,40584,40585,40590: [Backport #8367]

* insns.def (defined): get method entry from the method top level
  frame, not block frame.  [ruby-core:54769] [Bug #8367]

* insns.def (defined): use vm_search_superclass() like as normal super
  call.  based on a patch <https://gist.github.com/wanabe/5520026> by
  wanabe.

* vm_insnhelper.c (vm_search_superclass): return error but not raise
  exceptions.

* vm_insnhelper.c (vm_search_super_method): check the result of
  vm_search_superclass and raise execptions on error.
  vm_search_superclass and raise exceptions on error.
Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0Like0Like0