Bug #8968

Baseruby is required after patching configure.in

Added by Vit Ondruch 7 months ago. Updated 5 months ago.

[ruby-core:57476]
Status:Rejected
Priority:Normal
Assignee:Nobuyoshi Nakada
Category:-
Target version:-
ruby -v:ruby 2.1.0dev (2013-09-22 trunk 43011) [x86_64-linux] Backport:1.9.3: UNKNOWN, 2.0.0: UNKNOWN

Description

It sometimes happens, that during packaging Ruby, it is necessary to patch configure.in (we are doing so in Fedora, there are patches in Debian, RVM does so occasionally as well). Unfortunately, since rev 42685, if the configure.in is patched, it has newer timestamp than sizes.c and therefore sizes.c should be regenerated. For that Ruby is required. Unfortunately, miniruby is not build yet at that stage and we don't want to have other Ruby on the system, due to possible bootstrapping issues.

I can workaround it by touch sizes.c after the patch is applied, but is there change to remove/fix this dependency? Thanks.

Associated revisions

Revision 43137
Added by Nobuyoshi Nakada 7 months ago

common.mk: make sizes.c with MINIRUBY

  • common.mk (sizes.c): use MINIRUBY because Init_sizes() for miniruby is defined in miniinit.c and miniruby does not depend on this file. [Bug #8968]

Revision 43145
Added by Nobuyoshi Nakada 7 months ago

common.mk: sizes.c depends on PREP now

  • common.mk (sizes.c): now depends on PREP, which is miniruby if native compile or fake.rb otherwise, to run MINIRUBY [Bug #8968]

History

#1 Updated by Nobuyoshi Nakada 7 months ago

  • Status changed from Open to Third Party's Issue

#2 Updated by Yui NARUSE 7 months ago

  • Status changed from Third Party's Issue to Rejected

You should suggest acceptable plan.
You know such way is not acceptable.

#3 Updated by Vit Ondruch 7 months ago

naruse (Yui NARUSE) wrote:

You should suggest acceptable plan.
You know such way is not acceptable.

I know, but I had to report it for the record. I stay with 'touch' for now. Hopefully other folks come later with better idea.

#4 Updated by Nobuyoshi Nakada 7 months ago

Not only sizes.c, you need BASERUBY to generate some source files after touching template files.
It's your responsibility.

#5 Updated by Vit Ondruch 7 months ago

nobu (Nobuyoshi Nakada) wrote:

Not only sizes.c, you need BASERUBY to generate some source files after touching template files.
It's your responsibility.

Yes, it may happen that I may need to change some template for whatever reason, but configure.in is probably one of the first files which needs to be changed for whatever reason. For example similar patch like this one [1] is applied to Fedora's package for ages. Not sure if that makes sense to propose it upstream.

[1] http://pkgs.fedoraproject.org/cgit/ruby.git/tree/ruby-1.9.3-always-use-i386.patch

#6 Updated by Vit Ondruch 5 months ago

Thank you for fixing this.

Also available in: Atom PDF