Project

General

Profile

Actions

Bug #9101

closed

Reference to unset variable

Added by BertramScharpf (Bertram Scharpf) about 11 years ago. Updated over 8 years ago.

Status:
Closed
Assignee:
-
Target version:
-
ruby -v:
git revision e22d8781c8005b068ffa73ecc88728d720b6e870
[ruby-core:58264]

Description

File ext/openssl/ossl.c

line 1107, in Init_openssl(): call to ossl_raise()
line 1112, in Init_openssl(): first assignment to dOSSL

ossl_raise() calls ossl_make_error().
ossl_make_error() uses the global variable dOSSL (line 310).

==> ossl_raise() was called before dOSSL was set.

This will probably never cause any misbehaviour, but
nevertheless, it's definitely a bug.


Files

bs_fix_dossl.patch (1.45 KB) bs_fix_dossl.patch BertramScharpf (Bertram Scharpf), 11/11/2013 11:51 AM

Updated by BertramScharpf (Bertram Scharpf) about 11 years ago

Reminder: Not one single reaction for ten days.

Updated by BertramScharpf (Bertram Scharpf) about 11 years ago

Reminder: Not one single reaction in more than two weeks.

Updated by luislavena (Luis Lavena) about 11 years ago

  • Status changed from Open to Assigned
  • Assignee set to MartinBosslet (Martin Bosslet)
Actions #4

Updated by zzak (zzak _) over 9 years ago

  • Assignee changed from MartinBosslet (Martin Bosslet) to 7150
Actions #5

Updated by Anonymous over 8 years ago

  • Status changed from Assigned to Closed

Applied in changeset r55135.


openssl: Avoid reference to unset global variable in Init_openssl()

  • ext/openssl/ossl.c (Init_openssl): Avoid reference to unset global
    variable. ossl_raise() may be called before dOSSL is set. Since
    global variables default to 0 and the default value of dOSSL set in
    Init_openssl() is also Qfalse, there is no real issue but confusing.
    Patch by Bertram Scharpf
    [ruby-core:58264] [Bug #9101]
Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0Like0