Feature #9179
closedMatchData#values_at should support named capture
Description
=begin
Using (({MatchData#[]})), we can access a named capture by its name.
/(?...)/.match("foo")[:a] #=> "foo"
/(?...)/.match("foo")["a"] #=> "foo"
But (({MatchData#values_at})) accepts only Integer and refuses Symbol or String.
/(?...)/.match("foo").values_at(:a)
I expected it returns ["foo"], but...¶
#=> in `values_at': no implicit conversion of Symbol into Integer (TypeError)
(These are tested in ruby 2.1.0dev (2013-11-28 trunk 43903) [i686-linux].)
I think (({MatchData#values_at})) should work along with (({MathData#[]})) as follows:
/(?...)/.match("foo").values_at(:a) #=> ["foo"]
/(?...)/.match("foo").values_at("a") #=> ["foo"]
In the patch, (({match_entry})) is removed because it is no longer used. Comments and code are based on (({rb_hash_values_at})) in hash.c. It passes (({make test-all})) except (({TestGc#test_gc_reason})), which fails also on the original version.
=end
Files
Updated by naruse (Yui NARUSE) about 10 years ago
- Status changed from Open to Assigned
- Assignee set to matz (Yukihiro Matsumoto)
I want to write following code, how do you think matz?
reg = %r<\A(?<scheme>[A-Za-z][+\-.0-9A-Za-z]*):(?<hier-part>//(?<authority>[^/\\?#]+)(?<path-absolute>/[^?#]*)|[^/?#][^?#]*|)(?:\?(?<query>[^#]*))?(?:#(?<fragment>.*))?\z>
url = "http://example.com/hoge?foo=Bar#frag"
reg =~ url
p $~.values_at(:scheme, :authority, :"path-absolute", :query, :fragment)
Updated by naruse (Yui NARUSE) over 8 years ago
- Status changed from Assigned to Closed
Applied in changeset r55036.
-
re.c (match_values_at): MatchData#values_at supports named captures
[Feature #9179] -
re.c (namev_to_backref_number): separeted.