Bug #9184
closedBuild failure on Windows introduced by r43910
Description
r43910 introduced a build failure in RubyInstaller CI:
http://ci.rubyinstaller.org/job/ruby-trunk-x86-build/2730/console
compiling ../../../ext/win32ole/win32ole.c
../../../ext/win32ole/win32ole.c:3305:1: error: conflicting types for 'hash2named_arg'
../../../ext/win32ole/win32ole.c:386:14: note: previous declaration of 'hash2named_arg' was here
make[2]: *** [win32ole.o] Error 1
Here is a patch.
diff --git a/win32ole.c b/win32ole.c.new
index 9254ca4..66d05f8 100644
--- a/win32ole.c
+++ b/win32ole.c.new
@@ -383,7 +383,7 @@ static VALUE fole_s_create_guid(VALUE self);
static VALUE fole_s_ole_initialize(VALUE self);
static VALUE fole_s_ole_uninitialize(VALUE self);
static VALUE fole_initialize(int argc, VALUE argv, VALUE self);
-static VALUE hash2named_arg(VALUE pair, struct oleparam pOp);
+static VALUE hash2named_arg(RB_BLOCK_CALL_FUNC_ARGLIST(pair,pOp));
static VALUE set_argv(VARIANTARG* realargs, unsigned int beg, unsigned int end);
static VALUE ole_invoke(int argc, VALUE *argv, VALUE self, USHORT wFlags, BOOL is_bracket);
static VALUE fole_invoke(int argc, VALUE *argv, VALUE self);
Updated by nobu (Nobuyoshi Nakada) over 10 years ago
- Status changed from Open to Closed
- % Done changed from 0 to 100
This issue was solved with changeset r43932.
Heesob, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
win32ole.c: correct declaration
- ext/win32ole/win32ole.c (hash2named_arg): correct declaration to fix
build failure. a patch by phasis68 (Heesob Park) at
[ruby-core:58710]. [Bug #9184]