Project

General

Profile

Actions

Bug #9277

closed

REXML fails to parse comments with multiple dashes ('-') in them

Added by bhollis (Ben Hollis) over 8 years ago. Updated over 8 years ago.

Status:
Rejected
Priority:
Normal
Assignee:
-
Target version:
-
ruby -v:
ruby 2.0.0p247 (2013-06-27 revision 41674) [x86_64-darwin12.3.0]
[ruby-core:<unknown>]

Description

=begin
REXML cannot handle multiple dashes in a comment:

require 'rexml/document'
REXML::Document.new('<!-- -- -->')
=end

=begin
REXML::ParseException: #<REXML::ParseException: Malformed comment
Line: 1
Position: 24
Last 80 unconsumed characters:

/Users/foo/.rvm/rubies/ruby-2.0.0-p247/lib/ruby/2.0.0/rexml/parsers/baseparser.rb:351:in pull_event' /Users/foo/.rvm/rubies/ruby-2.0.0-p247/lib/ruby/2.0.0/rexml/parsers/baseparser.rb:183:in pull'
/Users/foo/.rvm/rubies/ruby-2.0.0-p247/lib/ruby/2.0.0/rexml/parsers/treeparser.rb:22:in parse' /Users/foo/.rvm/rubies/ruby-2.0.0-p247/lib/ruby/2.0.0/rexml/document.rb:283:in build'
/Users/foo/.rvm/rubies/ruby-2.0.0-p247/lib/ruby/2.0.0/rexml/document.rb:43:in `initialize'

...
Malformed comment
Line: 1
Position: 24
Last 80 unconsumed characters:

Line: 1
Position: 24
Last 80 unconsumed characters:

from /Users/foo/.rvm/rubies/ruby-2.0.0-p247/lib/ruby/2.0.0/rexml/parsers/treeparser.rb:95:in `rescue in parse'  
from /Users/foo/.rvm/rubies/ruby-2.0.0-p247/lib/ruby/2.0.0/rexml/parsers/treeparser.rb:20:in `parse' 
from /Users/foo/.rvm/rubies/ruby-2.0.0-p247/lib/ruby/2.0.0/rexml/document.rb:283:in `build'
from /Users/foo/.rvm/rubies/ruby-2.0.0-p247/lib/ruby/2.0.0/rexml/document.rb:43:in `initialize'
    <extra stack trace ommitted>

=end

Actions #1

Updated by zzak (Zachary Scott) over 8 years ago

  • Category set to lib
  • Status changed from Open to Assigned
  • Assignee set to kou (Kouhei Sutou)

Updated by mame (Yusuke Endoh) over 8 years ago

As I recall correctly, the XML spec does not allow "--" in a comment.

http://en.wikipedia.org/wiki/XML#Comments

The string "--" (double-hyphen) is not allowed inside comments

--
Yusuke Endoh

Updated by duerst (Martin Dürst) over 8 years ago

  • Status changed from Assigned to Rejected
  • Assignee deleted (kou (Kouhei Sutou))

mame (Yusuke Endoh) wrote:

As I recall correctly, the XML spec does not allow "--" in a comment.

Yes indeed. See http://www.w3.org/TR/xml/#sec-comments:

"For compatibility, the string " -- " (double-hyphen) MUST NOT occur within comments."

As for the phrase "for compatibility", this is what the spec says (http://www.w3.org/TR/xml/#dt-compat):
"for compatibility [Definition: Marks a sentence describing a feature of XML included solely to ensure that XML remains compatible with SGML.]"

So I have rejected this bug.

Actions

Also available in: Atom PDF