Bug #9504

X509 certificate incorrectly loaded (because of try-pem-first-else-asn1)

Added by Mark Schloesser over 1 year ago. Updated over 1 year ago.

[ruby-core:60588]
Status:Assigned
Priority:Normal
Assignee:Martin Bosslet
ruby -v:ruby 1.9.3p484 (2013-11-22 revision 43786) [x86_64-linux] Backport:1.9.3: UNKNOWN, 2.0.0: UNKNOWN, 2.1: UNKNOWN

Description

Ruby's openssl extension tries to load certificates as PEM format first, and on failure will try to do DER / ASN1. The PEM format loading ignores junk in the beginning and end of the given buffer, which can lead to a DER certificate being incorrectly loaded. This occurs on 1.9.3 and 2.2.0.

More concretely this occurs in the wild when a server certificate has a X509 extension comment that includes another certificate in PEM format. Example below.

To fix this, one could allow the user to optionally specify the format, and do DER directly if specified. That would keep things backwards compatible and allow these certificates to be correctly parsed.

Example certificate - http://pastebin.com/V90dDSez
Openssl output for this - http://pastebin.com/GSsLtP8J

Ruby script to show the bug/problem - http://pastebin.com/Q7ap7FjN

I currently patched my ruby version (1.9.3) like this: http://pastebin.com/HzyyAm0p

Thanks for feedback and incorporating the patch / a similar solution for this into Ruby.

History

#1 Updated by Mark Schloesser over 1 year ago

My patch means you can load the certificate like this:

x509 = OpenSSL::X509::Certificate.new(cert, "DER")

I guess having some module level constants for this (FILETYPE_PEM, FILETYPE_ASN1) would be better. Sadly I'm not a ruby guy by day, and I'd appreciate if someone cleans this up to be more clean :)

#2 Updated by Tomoyuki Chikanaga over 1 year ago

  • Status changed from Open to Assigned
  • Assignee set to Martin Bosslet

Hello, Mark.
Thank you for your reporting.

Martin, could you handle this?

Also available in: Atom PDF