Project

General

Profile

Bug #9560

Backport fix for: "SimpleDelegator, a wrapped object with an open method and send" from 2.1 to 2.0

Added by PragTob (Tobias Pfeiffer) over 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Target version:
-
[ruby-core:61053]

Description

There was an issue when you have an object with an open method wrapped by a SimpleDelegator and then use "send :open". This gist illustrates it: https://gist.github.com/PragTob/9189371

There was a github pull request fixing it: https://github.com/ruby/ruby/pull/449

It works for me on 2.1 (and 2.1.1) but it seems not to have been backported to the 2.0 series (tried -p451 today).

It'd be great if it were backported, could save people other than me quite some time and nerves :) It's a nasty thing to track down.

Cheers + thanks,
Tobi

History

#1 [ruby-core:61076] Updated by naruse (Yui NARUSE) over 3 years ago

  • Status changed from Open to Closed
  • Backport changed from 1.9.3: UNKNOWN, 2.0.0: UNKNOWN, 2.1: UNKNOWN to 1.9.3: REQUIRED, 2.0.0: REQUIRED, 2.1: DONTNEED

Backport r43752

#2 [ruby-core:62240] Updated by usa (Usaku NAKAMURA) about 3 years ago

  • Backport changed from 1.9.3: REQUIRED, 2.0.0: REQUIRED, 2.1: DONTNEED to 1.9.3: REQUIRED, 2.0.0: DONE, 2.1: DONTNEED

backported r43682 (test), r43727 (test), r43752 and r43759 into ruby_2_0_0 at r45747.

note: also implement assert_raise_with_message for these tests.

#3 [ruby-core:62248] Updated by usa (Usaku NAKAMURA) about 3 years ago

  • Backport changed from 1.9.3: REQUIRED, 2.0.0: DONE, 2.1: DONTNEED to 1.9.3: REQUIRED, 2.0.0: REQUIRED, 2.1: DONTNEED

oops, it's reverted on ruby_2_0_0 because of incompatibility...

Also available in: Atom PDF