Even though it can be a pain, please split unrelated patches in different requests.
Unify && vs and:
Thanks, this is good.
I reorder methods. I think Matrix#real should be upon Matrix#imaginary
Methods are sorted alphabetically within sections. I believe this was the original convention when I became committer. I see no compelling reason to change this.
There are both send :xxx and send(:xxx) expressions
Naohisa Goto: Good point about __send__, I imagine it is to avoid classes that redefined send? In any case, I revised the uses of send in the Matrix lib and they are all to call our own private methods, so I think it's fine like this.
Naohisa Goto: Good point about send, I imagine it is to avoid classes that redefined send? In any case, I revised the uses of send in the Matrix lib and they are all to call our own private methods, so I think it's fine like this.
Yes, using send is fine when calling Matrix classes' methods which are under your maintenance. When calling other classes which may not have the original behavior of send method, using "send" is better.
Even though it can be a pain, please split unrelated patches in different requests.
Sorry, I'm not familiar with how to use redmine. so you mean I need to make new 2 features?
(About unify_product_operator.patch, about reorder_Matrix#real_and_Matrix_imaginary.patch)
I reorder methods. I think Matrix#real should be upon Matrix#imaginary
Methods are sorted alphabetically within sections. I believe this was the original convention when I became committer. I see no compelling reason to change this.
Updated by 
Updated by 
Updated by