Project

General

Profile

Actions

Bug #10144

closed

[PATCH] time_timespec: fix tv_nsec overflow on float conversion

Added by normalperson (Eric Wong) over 9 years ago. Updated over 9 years ago.

Status:
Closed
Target version:
ruby -v:
trunk
[ruby-core:64407]

Description

test/ruby/test_float.rb (test_sleep_with_Float) causes tv_nsec
to hit 1000000000 exactly. This bug is currently hidden from
our test by the platform-dependent native_cond_timeout
functions, but a future native_cond_timedwait implementation may
prefer relative timeouts to match ConditionVariable#wait
semantics more closely.

Requesting backport since this may affect 3rd party C extensions.


Files

tv_nsec-overflow.patch (426 Bytes) tv_nsec-overflow.patch normalperson (Eric Wong), 08/16/2014 01:19 AM
Actions #1

Updated by Anonymous over 9 years ago

  • % Done changed from 0 to 100
  • Status changed from Open to Closed

Applied in changeset r47196.


time.c (time_timespec): fix tv_nsec overflow

test/ruby/test_float.rb (test_sleep_with_Float) causes tv_nsec
to hit 1000000000 exactly. This bug is currently hidden from
our test by the platform-dependent native_cond_timeout
functions, but a future native_cond_timedwait implementation may
prefer relative timeouts to match ConditionVariable#wait
semantics more closely.
[Bug #10144]

Updated by nagachika (Tomoyuki Chikanaga) over 9 years ago

  • Backport changed from 2.0.0: REQUIRED, 2.1: REQUIRED to 2.0.0: REQUIRED, 2.1: DONE

Backported into ruby_2_1 branch at r47482.

Updated by usa (Usaku NAKAMURA) over 9 years ago

  • Backport changed from 2.0.0: REQUIRED, 2.1: DONE to 2.0.0: DONE, 2.1: DONE

backported into ruby_2_0_0 at r47501.

Actions

Also available in: Atom PDF

Like0
Like0Like0Like0