Project

General

Profile

Feature #10365

`Rational#to_a` and `Array#to_r`

Added by sawa (Tsuyoshi Sawada) almost 5 years ago. Updated almost 5 years ago.

Status:
Rejected
Priority:
Normal
Assignee:
-
Target version:
-
[ruby-core:65604]

Description

I guess people would want to extract the numerator and the denominator of an array. to_a would perhaps be a good name:

(2/51).to_a # => [2, 51]

It also might be useful if Array#to_r were provided as an alternative way to create a rational from an array:

[4, 6].to_r #=> (2/3)

This would be equivalent to Rational(*[4, 6]).

History

Updated by sawa (Tsuyoshi Sawada) almost 5 years ago

Sorry, I meant

2/51r.to_a # => [2, 51]

Updated by nobu (Nobuyoshi Nakada) almost 5 years ago

IMHO, splatting a rational doesn't feel to make sense, so to_a doesn't feel appropriate.

Updated by jeremyevans0 (Jeremy Evans) almost 5 years ago

Wouldn't the proposed Rational#to_a break backwards compatibility, as well as consistency with other numeric classes:

Currently:

Array(1) # => [1]
Array(1.0) # => [1.0]
Array(BigDecimal.new('1.0')) # => [#]
Array(Complex(1, 2)) => [(1+2i)]
Array(1/2r) # => [(1/2)]

With proposed method:

Array(1/2r) # => [1, 2]

Updated by sawa (Tsuyoshi Sawada) almost 5 years ago

I think Nobuyoshi Nakada and Jeremy Evans are right. I will withdraw to_a from the proposal.

Updated by matz (Yukihiro Matsumoto) almost 5 years ago

  • Status changed from Open to Rejected

And without having Rational#to_a, Array#to_r does not mean much.
So I reject this.

Matz.

Updated by nobu (Nobuyoshi Nakada) almost 5 years ago

Just a memo:

[1, 2].inject(:quo) #=> (1/2)

Updated by sawa (Tsuyoshi Sawada) almost 5 years ago

Nobuyoshi Nakada wrote:

Just a memo:

[1, 2].inject(:quo) #=> (1/2)

Thanks for the information.

Also available in: Atom PDF