Project

General

Profile

Bug #10372

Problem with relative paths in update-gems makefile rule (common.mk)

Added by duerst (Martin Dürst) about 5 years ago. Updated about 5 years ago.

Status:
Closed
Priority:
Normal
Target version:
ruby -v:
ruby 2.2.0dev (2014-09-27 trunk 47722) [x86_64-cygwin]
[ruby-core:65630]

Description

When I do

make update-gems
I get the following error:

-e:1:in `require': cannot load such file -- downloader (LoadError)
uncommon.mk:1084: recipe for target 'update-gems' failed
make: *** [update-gems] Error 1

The reason for this seems to be a problem with relative paths.
The rule for update-gems in common.mk is as follows:

update-gems: PHONY
    $(ECHO) Downloading bundled gem files...
    $(Q) $(RUNRUBY) -I$(srcdir)/tool -rdownloader -answ \
        -C "$(srcdir)/gems" \
        -e 'gem, ver = *$$F' \
        -e 'gem = "#{gem}-#{ver}.gem"' \
        -e 'Downloader::RubyGems.download(gem)' \
        bundled_gems

$(srcdir) is just '.', and so './tool' gets added to the load path, but then -C "$(srcdir)/gems" changes to the gems subdirectory, from which './tool' doesn't point to the tool directory anymore.

Associated revisions

Revision 89322aaf
Added by hsbt (Hiroshi SHIBATA) about 5 years ago

  • common.mk: use relative load path for bundled_gems directory. [Bug #10372][ruby-core:65630]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47899 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 47899
Added by hsbt (Hiroshi SHIBATA) about 5 years ago

  • common.mk: use relative load path for bundled_gems directory. [Bug #10372][ruby-core:65630]

Revision 47899
Added by hsbt (Hiroshi SHIBATA) about 5 years ago

  • common.mk: use relative load path for bundled_gems directory. [Bug #10372][ruby-core:65630]

Revision 47899
Added by hsbt (Hiroshi SHIBATA) about 5 years ago

  • common.mk: use relative load path for bundled_gems directory. [Bug #10372][ruby-core:65630]

Revision 47899
Added by hsbt (Hiroshi SHIBATA) about 5 years ago

  • common.mk: use relative load path for bundled_gems directory. [Bug #10372][ruby-core:65630]

Revision 47899
Added by hsbt (Hiroshi SHIBATA) about 5 years ago

  • common.mk: use relative load path for bundled_gems directory. [Bug #10372][ruby-core:65630]

Revision 47899
Added by hsbt (Hiroshi SHIBATA) about 5 years ago

  • common.mk: use relative load path for bundled_gems directory. [Bug #10372][ruby-core:65630]

Revision f77d22d1
Added by nobu (Nobuyoshi Nakada) about 5 years ago

common.mk: update-gems for older BASERUBY

  • common.mk (update-gems): chdir to the target directory and then add the tool directory to load paths, for older BASERUBY. [Bug #10372][ruby-core:65630]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47904 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 47904
Added by nobu (Nobuyoshi Nakada) about 5 years ago

common.mk: update-gems for older BASERUBY

  • common.mk (update-gems): chdir to the target directory and then add the tool directory to load paths, for older BASERUBY. [Bug #10372][ruby-core:65630]

Revision 47904
Added by nobu (Nobuyoshi Nakada) about 5 years ago

common.mk: update-gems for older BASERUBY

  • common.mk (update-gems): chdir to the target directory and then add the tool directory to load paths, for older BASERUBY. [Bug #10372][ruby-core:65630]

Revision 47904
Added by nobu (Nobuyoshi Nakada) about 5 years ago

common.mk: update-gems for older BASERUBY

  • common.mk (update-gems): chdir to the target directory and then add the tool directory to load paths, for older BASERUBY. [Bug #10372][ruby-core:65630]

Revision 47904
Added by nobu (Nobuyoshi Nakada) about 5 years ago

common.mk: update-gems for older BASERUBY

  • common.mk (update-gems): chdir to the target directory and then add the tool directory to load paths, for older BASERUBY. [Bug #10372][ruby-core:65630]

Revision 47904
Added by nobu (Nobuyoshi Nakada) about 5 years ago

common.mk: update-gems for older BASERUBY

  • common.mk (update-gems): chdir to the target directory and then add the tool directory to load paths, for older BASERUBY. [Bug #10372][ruby-core:65630]

Revision 47904
Added by nobu (Nobuyoshi Nakada) about 5 years ago

common.mk: update-gems for older BASERUBY

  • common.mk (update-gems): chdir to the target directory and then add the tool directory to load paths, for older BASERUBY. [Bug #10372][ruby-core:65630]

History

Updated by hsbt (Hiroshi SHIBATA) about 5 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

Applied in changeset r47899.


  • common.mk: use relative load path for bundled_gems directory. [Bug #10372][ruby-core:65630]

Updated by nobu (Nobuyoshi Nakada) about 5 years ago

  • Description updated (diff)
  • Status changed from Closed to Open

Which version of ruby are you using to download the files?
Since 1.9, -I directories are expanded to absolute paths.

Updated by nobu (Nobuyoshi Nakada) about 5 years ago

  • Status changed from Open to Closed

Applied in changeset r47904.


common.mk: update-gems for older BASERUBY

  • common.mk (update-gems): chdir to the target directory and then add the tool directory to load paths, for older BASERUBY. [Bug #10372][ruby-core:65630]

Updated by hsbt (Hiroshi SHIBATA) about 5 years ago

I got same error with ruby trunk.

Also available in: Atom PDF