Project

General

Profile

Feature #10501

[PATCH] insns.def (opt_succ): remove Time#succ optimization

Added by normalperson (Eric Wong) over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Target version:
[ruby-core:66233]

Description

Time#succ is a deprecated method and not frequently used, so this wastes
icache in vm_exec_core.  Using bloat-o-meter in the Linux kernel source
to shows a small reduction on my x86-64 system:

$ ~/linux/scripts/bloat-o-meter ruby.before ruby.after
add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-57 (-57)
function                                     old     new   delta
vm_exec_core                               24216   24159     -57

There should be no problems, I'll commit in a day or two.

Files

Updated by phluid61 (Matthew Kerwin) over 5 years ago

A timely request. Please note this question on omniref from a couple of days ago, regarding Time ranges (and the implicit use of Time#succ). It seems people aren't aware of the deprecation, and may be quite surprised to find the method missing. I'm not sure just how widespread its use, though.

#3

Updated by Anonymous over 5 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

Applied in changeset r48415.


insns.def (opt_succ): remove Time#succ optimization

Time#succ is a deprecated method and not frequently used, so this wastes
icache in vm_exec_core. Using bloat-o-meter in the Linux kernel source
to shows a small reduction on my x86-64 system:

$ ~/linux/scripts/bloat-o-meter ruby.before ruby.after
add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-57 (-57)
function old new delta
vm_exec_core 24216 24159 -57

[Feature #10501]

Also available in: Atom PDF