Project

General

Profile

Actions

Feature #10900

closed

GzipReader does not define `#external_encoding`

Added by akostadinov (Aleksandar Kostadinov) about 9 years ago. Updated almost 9 years ago.

Status:
Closed
Assignee:
-
Target version:
-
[ruby-core:68287]

Description

Hello,

I want to store/load some yaml and other text data in gz for space efficiency. I thought it's most efficient to read/write directly to/from a gzip stream. But seems like the GzipReader io object does not support everything that a regular file io object does. I spotted the #external_encoding method. So for example to load YAML directly from gzip I use the following method:

    def load_yaml_from_gz(gz)
      loaded = nil
      Zlib::GzipReader.open(gz) do |f|
        class << f
          def external_encoding
            Encoding::UTF_8
          end
        end
        loaded = YAML.load(f, gz)
      end
      return loaded
    end

I need the monkey-patching because otherwise the YAML.load method fails for no #external_encoding method defined.

To avoid monkey patching just to read some text from a gzip archive I propose that GzipReader implements #external_encoding the same way as File does.

Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0