Project

General

Profile

Actions

Feature #10958

closed

remove "initial_state" argument of Enumerable#{slice_before,chunk}

Added by akr (Akira Tanaka) about 9 years ago. Updated almost 9 years ago.

Status:
Closed
Assignee:
-
Target version:
-
[ruby-core:<unknown>]

Description

I'd like to remove "initial_state" argument of Enumerable#{slice_before,chunk}.

I think a state management can be implemented using local variable without the argument.
So I'd like to remove it because it is too complex and
not consistent with Enumerable#{slice_when,slice_after} which doesn't have the argument.

Note that I added deprecated warning since Ruby 2.2.
It seems no one complained the warning until now.


Files


Related issues 1 (0 open1 closed)

Related to Ruby master - Bug #13202: Enumerable#slice_before does not take both argument and block at the same time, as it ought to.ClosedActions
Actions #1

Updated by Eregon (Benoit Daloze) about 9 years ago

+1, making these two simpler is definitely an improvement!

Actions #2

Updated by akr (Akira Tanaka) almost 9 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

Applied in changeset r50174.


  • enum.c: Enumerable#chunk and Enumerable#slice_before no longer takes
    the initial_state argument. [Feature #10958]
Actions #3

Updated by akr (Akira Tanaka) almost 9 years ago

It seems no one against this. I committed.

Actions #4

Updated by naruse (Yui NARUSE) about 7 years ago

  • Related to Bug #13202: Enumerable#slice_before does not take both argument and block at the same time, as it ought to. added
Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0