Project

General

Profile

Bug #11045

ruby/test_m17n_comb.rb test_str_crypt tests platform-specific crypt behavior

Added by headius (Charles Nutter) over 4 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Normal
Target version:
-
[ruby-core:<unknown>]

Description

I think we should just remove the glibc version guards in test_str_crypt in test/ruby/test_m17n_comb.rb.

  1. JRuby can't determine glibc version without making a glibc-specific call (because we have no build-time configure script or similar)
  2. On platforms that use glibc but don't report version, this guard won't work.
  3. Do we really want to be testing linux-specific crypt behavior?

I propose that we just make the test skip non-alpha salt unconditionally.

Associated revisions

Revision 2d1f3ed1
Added by headius (Charles Nutter) about 4 years ago

  • test/ruby/test_m17n_comb.rb: test_str_crypt split into strict and non-strict versions to allow masking out non-strict when glibc version cannot be determined (#11045).

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50366 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 50366
Added by headius (Charles Nutter) about 4 years ago

  • test/ruby/test_m17n_comb.rb: test_str_crypt split into strict and non-strict versions to allow masking out non-strict when glibc version cannot be determined (#11045).

Revision 50366
Added by headius (Charles Nutter) about 4 years ago

  • test/ruby/test_m17n_comb.rb: test_str_crypt split into strict and non-strict versions to allow masking out non-strict when glibc version cannot be determined (#11045).

Revision 50366
Added by headius (Charles Nutter) about 4 years ago

  • test/ruby/test_m17n_comb.rb: test_str_crypt split into strict and non-strict versions to allow masking out non-strict when glibc version cannot be determined (#11045).

Revision 50366
Added by headius (Charles Nutter) about 4 years ago

  • test/ruby/test_m17n_comb.rb: test_str_crypt split into strict and non-strict versions to allow masking out non-strict when glibc version cannot be determined (#11045).

Revision 50366
Added by headius (Charles Nutter) about 4 years ago

  • test/ruby/test_m17n_comb.rb: test_str_crypt split into strict and non-strict versions to allow masking out non-strict when glibc version cannot be determined (#11045).

Revision aa4dc2b0
Added by nagachika (Tomoyuki Chikanaga) about 4 years ago

merge revision(s) 50366: [Backport #11045]

    * test/ruby/test_m17n_comb.rb: test_str_crypt split into strict

and non-strict versions to allow masking out non-strict when
glibc version cannot be determined (#11045).

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@51130 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 51130
Added by nagachika (Tomoyuki Chikanaga) about 4 years ago

merge revision(s) 50366: [Backport #11045]

* test/ruby/test_m17n_comb.rb: test_str_crypt split into strict

and non-strict versions to allow masking out non-strict when
glibc version cannot be determined (#11045).

History

#1

Updated by nobu (Nobuyoshi Nakada) over 4 years ago

Charles Nutter wrote:

  1. Do we really want to be testing linux-specific crypt behavior?

I don't think we want, it's just an implementation regression test.

I propose that we just make the test skip non-alpha salt unconditionally.

Or we need a standard way to isolate this kind of tests.

#2

Updated by headius (Charles Nutter) over 4 years ago

Nobuyoshi Nakada wrote:

Or we need a standard way to isolate this kind of tests.

That's not a bad idea, actually. I will split the Linux-specific regression part into a separate test. JRuby uses excludes to mask tests, so that will allow us to exclude the platform-specific one.

#3

Updated by headius (Charles Nutter) about 4 years ago

  • Status changed from Open to Closed

Fixed by r50366.

#4

Updated by headius (Charles Nutter) about 4 years ago

  • Assignee set to headius (Charles Nutter)

Updated by usa (Usaku NAKAMURA) about 4 years ago

  • Backport changed from 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN to 2.0.0: WONTFIX, 2.1: REQUIRED, 2.2: REQUIRED

Updated by usa (Usaku NAKAMURA) about 4 years ago

  • Backport changed from 2.0.0: WONTFIX, 2.1: REQUIRED, 2.2: REQUIRED to 2.0.0: DONTNEED, 2.1: DONTNEED, 2.2: REQUIRED

Updated by nagachika (Tomoyuki Chikanaga) about 4 years ago

  • Backport changed from 2.0.0: DONTNEED, 2.1: DONTNEED, 2.2: REQUIRED to 2.0.0: DONTNEED, 2.1: DONTNEED, 2.2: DONE

Backported into ruby_2_2 branch at r51130.

Also available in: Atom PDF