Project

General

Profile

Actions

Bug #11045

closed

ruby/test_m17n_comb.rb test_str_crypt tests platform-specific crypt behavior

Added by headius (Charles Nutter) almost 9 years ago. Updated over 8 years ago.

Status:
Closed
Target version:
-
[ruby-core:<unknown>]

Description

I think we should just remove the glibc version guards in test_str_crypt in test/ruby/test_m17n_comb.rb.

  1. JRuby can't determine glibc version without making a glibc-specific call (because we have no build-time configure script or similar)
  2. On platforms that use glibc but don't report version, this guard won't work.
  3. Do we really want to be testing linux-specific crypt behavior?

I propose that we just make the test skip non-alpha salt unconditionally.

Actions #1

Updated by nobu (Nobuyoshi Nakada) almost 9 years ago

Charles Nutter wrote:

  1. Do we really want to be testing linux-specific crypt behavior?

I don't think we want, it's just an implementation regression test.

I propose that we just make the test skip non-alpha salt unconditionally.

Or we need a standard way to isolate this kind of tests.

Actions #2

Updated by headius (Charles Nutter) almost 9 years ago

Nobuyoshi Nakada wrote:

Or we need a standard way to isolate this kind of tests.

That's not a bad idea, actually. I will split the Linux-specific regression part into a separate test. JRuby uses excludes to mask tests, so that will allow us to exclude the platform-specific one.

Actions #3

Updated by headius (Charles Nutter) almost 9 years ago

  • Status changed from Open to Closed

Fixed by r50366.

Actions #4

Updated by headius (Charles Nutter) almost 9 years ago

  • Assignee set to headius (Charles Nutter)

Updated by usa (Usaku NAKAMURA) over 8 years ago

  • Backport changed from 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN to 2.0.0: WONTFIX, 2.1: REQUIRED, 2.2: REQUIRED

Updated by usa (Usaku NAKAMURA) over 8 years ago

  • Backport changed from 2.0.0: WONTFIX, 2.1: REQUIRED, 2.2: REQUIRED to 2.0.0: DONTNEED, 2.1: DONTNEED, 2.2: REQUIRED

Updated by nagachika (Tomoyuki Chikanaga) over 8 years ago

  • Backport changed from 2.0.0: DONTNEED, 2.1: DONTNEED, 2.2: REQUIRED to 2.0.0: DONTNEED, 2.1: DONTNEED, 2.2: DONE

Backported into ruby_2_2 branch at r51130.

Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0Like0Like0Like0