Bug #11080: [PERF] bm_so_concatenate.rb regression

• Status: Closed
• Assignee: nobu (Nobuyoshi Nakada)
• Target version: -
• ruby -v: ruby 2.3.0dev (2015-04-17 trunk 50336) [x86_64-linux]
• Backport: 2.0.0: DONTNEED, 2.1: DONTNEED, 2.2: DONTNEED

[tgxworld (Guo Xiang Tan)]

http://rubybench.org/ruby/ruby/commits?result_type=so_concatenate&display_count=1000

Hi, I spotted a regression on bm_so_concatenate.rb due to https://github.com/ruby/ruby/commit/b3626b3.

Before b3626b3: 2.665s
After b3626b3: 5.377s

Do let me know if there are more information that I can provide to help out with this issue. Thank you in advance!

[nobu (Nobuyoshi Nakada)]

• Related to Bug #11095: severe performance regression since r50336 added

[nobu (Nobuyoshi Nakada)]

• Related to deleted (Bug #11095: severe performance regression since r50336)

[nobu (Nobuyoshi Nakada)]

• Is duplicate of Bug #11095: severe performance regression since r50336 added

[nobu (Nobuyoshi Nakada)]

• Status changed from Open to Closed
• % Done changed from 0 to 100

Applied in changeset r50386.

---

revert r50336

• string.c (str_buf_cat): expand later so that the buffer can be
  larger for further use. [Bug #11080] [Bug #11080]

[tgxworld (Guo Xiang Tan)]

Thank you for your work Nobu!

[usa (Usaku NAKAMURA)]

• Backport changed from 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN to 2.0.0: DONTNEED, 2.1: DONTNEED, 2.2: DONTNEED