Feature #11356: Add ECDH support to OpenSSL wrapper

• Status: Closed
• Assignee: -
• Target version: -

[tenderlovemaking (Aaron Patterson)]

FireFox wants to use ECDH on HTTP/2 connections, and there is no way to add it to the SSL context. This patch adds an ECDH callback (similar to the DH callback).

With this patch and #9390, I am able to get an HTTP/2 server running in Chrome and FireFox! :)

[nobu (Nobuyoshi Nakada)]

static VALUE
ossl_call_tmp_ecdh_callback(VALUE *args)

I think this argument should be a VALUE and casted in the function.

    success = rb_protect((VALUE(*)_((VALUE)))ossl_call_tmp_ecdh_callback,
                         (VALUE)args, NULL);

Then we can remove the cast of the function and an indirect cast.

[tenderlovemaking (Aaron Patterson)]

• File 0001-add-ecdh-support.patch 0001-add-ecdh-support.patch added

@nobu (Nobuyoshi Nakada),

Thanks for the feedback! I've attached a new patch that refactors those parts.

• Status changed from Open to Closed

Applied in changeset r51348.

---

• ext/openssl/ossl_ssl.c: add ECDH callback support. [Feature #11356]

• test/openssl/test_pair.rb: test for ECDH callback support

[rhenium (Kazuki Yamaguchi)]

• Related to Bug #10497: OpenSSL Servers Do Not Support EC Certificates added

[rhenium (Kazuki Yamaguchi)]

• Related to Bug #11739: OpenSSL::SSL::SSLServer doesn't negotiate ECDHE-* ciphersuites added