Project

General

Profile

Actions

Bug #11397

closed

rubygems tests slow after r51384

Added by normalperson (Eric Wong) over 8 years ago. Updated over 8 years ago.

Status:
Closed
Target version:
-
[ruby-core:70141]

Description

Attached is a proposed patch to memoize the tmp_dh_callback result for RubyGems,
similar to what existing OpenSSL, DRb, Net::HTTP tests already do.

Without this patch,

make test-all TESTS='test/rubygems/ -v -j4'

Runs for several minutes (I gave up waiting). This patch makes the rubygems
tests run in under 20 seconds on my 32-bit system.

OK to commit?


Files

memoize_dh_response.patch (2.25 KB) memoize_dh_response.patch normalperson (Eric Wong), 07/28/2015 05:07 AM

Updated by hsbt (Hiroshi SHIBATA) over 8 years ago

Thank you Eric.

We discussed this issue today.
Your solution is good to me.

Please commit it.

Actions #2

Updated by Anonymous over 8 years ago

  • Status changed from Open to Closed

Applied in changeset r51414.


test/rubygems/test_gem_remote_fetcher.rb: pre-generate test key

OpenSSL::PKey::DH.new(2048) takes forever, and we pre-generate
test keys for other SSL-using tests anyways.

Actions

Also available in: Atom PDF

Like0
Like0Like0