Actions
Bug #11397
closedrubygems tests slow after r51384
Description
Attached is a proposed patch to memoize the tmp_dh_callback result for RubyGems,
similar to what existing OpenSSL, DRb, Net::HTTP tests already do.
Without this patch,
make test-all TESTS='test/rubygems/ -v -j4'
Runs for several minutes (I gave up waiting). This patch makes the rubygems
tests run in under 20 seconds on my 32-bit system.
OK to commit?
Files
Updated by hsbt (Hiroshi SHIBATA) almost 10 years ago
Thank you Eric.
We discussed this issue today.
Your solution is good to me.
Please commit it.
Updated by Anonymous almost 10 years ago
- Status changed from Open to Closed
Applied in changeset r51414.
test/rubygems/test_gem_remote_fetcher.rb: pre-generate test key
OpenSSL::PKey::DH.new(2048) takes forever, and we pre-generate
test keys for other SSL-using tests anyways.
- test/rubygems/test_gem_remote_fetcher.rb: pre-generate test key
[ruby-core:70151] [Bug #11397]
Actions
Like0
Like0Like0