Actions
Misc #11548
closedFileUtils#remove_tailing_slash is a poor method name
Status:
Closed
Assignee:
Description
One would expect this method to be called remove_trailing_slash
I asked around on IRC and the consensus is this is probably an unfortunate typo that's survived too long.
Tailing and Trailing mean similar things, but I think most would expect "trailing" to be the clear choice here.
http://ruby-doc.org/stdlib-2.2.3/libdoc/fileutils/rdoc/FileUtils.html#method-i-remove_tailing_slash
Files
Updated by duerst (Martin Dürst) about 9 years ago
I agree. We should probably introduce the new name now, and later deprecate the old one.
Updated by nobu (Nobuyoshi Nakada) about 9 years ago
It's a private method, we can replace it immediately.
Updated by willianveiga (Willian Veiga) about 9 years ago
- File bug11548.patch bug11548.patch added
I have created a patch. This is my first contribution here. Sorry if I am doing something wrong.
Thank you very much.
Updated by hsbt (Hiroshi SHIBATA) about 9 years ago
- Status changed from Open to Closed
- Assignee set to hsbt (Hiroshi SHIBATA)
Actions
Like0
Like0Like0Like0Like0