Project

General

Profile

Misc #11548

FileUtils#remove_tailing_slash is a poor method name

Added by slash_nick (Ryan Hosford) over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
[ruby-core:<unknown>]

Description

One would expect this method to be called remove_trailing_slash

I asked around on IRC and the consensus is this is probably an unfortunate typo that's survived too long.

Tailing and Trailing mean similar things, but I think most would expect "trailing" to be the clear choice here.

http://ruby-doc.org/stdlib-2.2.3/libdoc/fileutils/rdoc/FileUtils.html#method-i-remove_tailing_slash


Files

bug11548.patch (1.83 KB) bug11548.patch willianveiga (Willian Veiga), 10/01/2015 01:17 PM

Associated revisions

Revision d7908f9a
Added by hsbt (Hiroshi SHIBATA) over 3 years ago

  • lib/fileutils.rb: rename tailing to trailing. [Misc #11548]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52285 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 52285
Added by hsbt (Hiroshi SHIBATA) over 3 years ago

  • lib/fileutils.rb: rename tailing to trailing. [Misc #11548]

Revision 52285
Added by hsbt (Hiroshi SHIBATA) over 3 years ago

  • lib/fileutils.rb: rename tailing to trailing. [Misc #11548]

Revision 52285
Added by hsbt (Hiroshi SHIBATA) over 3 years ago

  • lib/fileutils.rb: rename tailing to trailing. [Misc #11548]

Revision 52285
Added by hsbt (Hiroshi SHIBATA) over 3 years ago

  • lib/fileutils.rb: rename tailing to trailing. [Misc #11548]

Revision 52285
Added by hsbt (Hiroshi SHIBATA) over 3 years ago

  • lib/fileutils.rb: rename tailing to trailing. [Misc #11548]

History

#1

Updated by duerst (Martin Dürst) over 3 years ago

I agree. We should probably introduce the new name now, and later deprecate the old one.

#2

Updated by nobu (Nobuyoshi Nakada) over 3 years ago

It's a private method, we can replace it immediately.

#3

Updated by willianveiga (Willian Veiga) over 3 years ago

I have created a patch. This is my first contribution here. Sorry if I am doing something wrong.
Thank you very much.

Updated by hsbt (Hiroshi SHIBATA) over 3 years ago

  • Status changed from Open to Closed
  • Assignee set to hsbt (Hiroshi SHIBATA)

Also available in: Atom PDF