Project

General

Profile

Actions

Bug #11587

closed

Make OpenStruct#new_ostruct_member and #modifiable fully private API

Added by Eregon (Benoit Daloze) over 8 years ago. Updated about 8 years ago.

Status:
Closed
Assignee:
-
Target version:
-
[ruby-core:71069]

Description

#6056 made OpenStruct#new_ostruct_member and #modifiable protected,
but they still appear in RDoc and normal user documentation:
http://ruby-doc.org/stdlib-2.2.3/libdoc/ostruct/rdoc/OpenStruct.html#method-i-new_ostruct_member
Also, it seems they should really be private and not just protected.

These methods look like they should be implementation details and therefore be hidden from the user.

Is it fine from a compatibility point of view to make them private and hide them from user documentation?

Actions #1

Updated by nobu (Nobuyoshi Nakada) over 8 years ago

  • Status changed from Open to Closed

Applied in changeset r53987.


ostruct.rb: make internal methods private

  • lib/ostruct.rb (modifiable?, new_ostruct_member!, table!):
    rename methods for internal use with suffixes and make private,
    [ruby-core:71069] [Bug #11587]

Updated by usa (Usaku NAKAMURA) about 8 years ago

  • Backport changed from 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN to 2.1: WONTFIX, 2.2: REQUIRED, 2.3: REQUIRED

Updated by usa (Usaku NAKAMURA) about 8 years ago

  • Backport changed from 2.1: WONTFIX, 2.2: REQUIRED, 2.3: REQUIRED to 2.1: WONTFIX, 2.2: WONTFIX, 2.3: UNKNOWN
Actions

Also available in: Atom PDF

Like0
Like0Like0Like0