Bug #11702
closederrors in tests of logger on Windows
Description
Hi, sonots, welcome to ruby committers!
Your memorial first commit r52620 introduces two test errors on Windows.
Line 134 and 157 of test/logger/test_logdevice.rb is:
File.unlink(@filename) if File.exist?(@filename) # remove once, then reopen
but Windows cannot remove opened file.
Fix them, please.
If I will discover that they won't have been fixed on tomorrow morning, I will revert the commit.
Updated by usa (Usaku NAKAMURA) over 8 years ago
- Subject changed from errors in tests of logger to errors in tests of logger on Windows
- Status changed from Open to Assigned
- Assignee set to sonots (Naotoshi Seo)
Updated by usa (Usaku NAKAMURA) over 8 years ago
One more request.
Date and time of the entry of ChangeLog is not a date and time that you have made the changes,
but the timing of commit to the repository of ruby.
Updated by sonots (Naotoshi Seo) over 8 years ago
Oh, god. Thank you for pointing out. I will fix soon.
Updated by sonots (Naotoshi Seo) over 8 years ago
@Usaku Nakamura
I created a patch > https://github.com/sonots/ruby/commit/e438ac0b59bf70946947ee80a0f3aa82ef10cf9c. Cloud you check this?
I tried to create a build environment for Windows, but unfortunately it failed as https://gist.github.com/sonots/49e1830d7db19aef505b, and I could not verify by myself.
Updated by usa (Usaku NAKAMURA) over 8 years ago
Naotoshi Seo wrote:
I created a patch > https://github.com/sonots/ruby/commit/e438ac0b59bf70946947ee80a0f3aa82ef10cf9c. Cloud you check this?
Seems OK.
Commit it, please.
I tried to create a build environment for Windows, but unfortunately it failed as https://gist.github.com/sonots/49e1830d7db19aef505b, and I could not verify by myself.
Current trunk does NOT support VS2015.
Naruse-san tried before, and the results is here: https://github.com/nurse/ruby/tree/msvc14
But, IMO, you should try vs2013 or mingw, unless you want to be maintain vs2015 build.
Updated by sonots (Naotoshi Seo) over 8 years ago
- Status changed from Assigned to Closed
Applied in changeset r52628.
- test/logger/test_logdevice.rb: Fix tests of logger to make it work on
windows (windows can not remove opened file) [Bug #11702]
Updated by sonots (Naotoshi Seo) over 8 years ago
Thanks, I will try with vs2013, but anyway committed :)