Project

General

Profile

Actions

Feature #11749

closed

[PATCH] variable.c: remove spurious #define for globals

Feature #11749: [PATCH] variable.c: remove spurious #define for globals

Added by normalperson (Eric Wong) about 10 years ago. Updated about 10 years ago.

Status:
Closed
Assignee:
-
Target version:
-
[ruby-core:71728]

Description

variable.c: remove spurious #define for globals

Removing the indirection helps me with readability, at
least. It doesn't seem like there are many other places
in the Ruby code where macros are used like this.

@nobu (Nobuyoshi Nakada): They appeared in r19781 when the *_{getter,setter,marker}
methods were made public, presumably to minimize the size of the
diff.

Will commit in a week or so unless there are objections.


Files

Updated by nobu (Nobuyoshi Nakada) about 10 years ago Actions #1 [ruby-core:71735]

Eric Wong wrote:

@nobu (Nobuyoshi Nakada): They appeared in r19781 when the *_{getter,setter,marker}
methods were made public, presumably to minimize the size of the
diff.

Will commit in a week or so unless there are objections.

Yes, please fix it.

Updated by Anonymous about 10 years ago Actions #2

  • Status changed from Open to Closed

Applied in changeset r52790.


variable.c: remove spurious #define for globals

Removing the indirection helps me with readability, at
least. It doesn't seem like there are many other places
in the Ruby code where macros are used like this.

[ruby-core:71735] [Feature #11749]

Actions

Also available in: PDF Atom