Project

General

Profile

Actions

Feature #11982

closed

Rename test-sample

Feature #11982: Rename test-sample

Added by hsbt (Hiroshi SHIBATA) almost 10 years ago. Updated almost 10 years ago.

Status:
Closed
Target version:
-
[ruby-core:72823]

Description

Ruby test suites named make check are following instructions.

  • test
  • test-sample
  • btest-ruby
  • test-knownbug
  • test-testframework
  • test-almost

test-sample invokes sample/test.rb. It name is sample, but it's not sample code.
It contains basically syntax tests, assigning tests, etc.

It should be move before test-testframework and after btest-ruby.
I propose to rename test-sample and change dependency order.

What name that we use instead of test-sample ? Example for

  • test-init
  • test-traditional
  • test-zero

Updated by usa (Usaku NAKAMURA) almost 10 years ago Actions #1 [ruby-core:72825]

Hiroshi SHIBATA wrote:

It contains basically syntax tests, assigning tests, etc.

You've already found the suitable name.
test-basical is good enough, I think.

Updated by Eregon (Benoit Daloze) almost 10 years ago Actions #2 [ruby-core:72826]

Usaku NAKAMURA wrote:

Hiroshi SHIBATA wrote:

It contains basically syntax tests, assigning tests, etc.

You've already found the suitable name.
test-basical is good enough, I think.

test-basic maybe?

Updated by usa (Usaku NAKAMURA) almost 10 years ago Actions #3 [ruby-core:72827]

Benoit Daloze wrote:

test-basic maybe?

You are right. I have to learn English :-(

Updated by hsbt (Hiroshi SHIBATA) almost 10 years ago Actions #4

  • Status changed from Open to Closed

Applied in changeset r53537.


  • common.mk: test-sample was changed to test-basic.
    [Feature #11982][ruby-core:72823]
  • basictest/runner.rb: ditto. rename from tool/rubytest.rb.
  • basictest/test.rb: ditto. rename from sample/test.rb.

Updated by hsbt (Hiroshi SHIBATA) almost 10 years ago Actions #5 [ruby-core:72875]

  • Status changed from Closed to Open

Updated by hsbt (Hiroshi SHIBATA) almost 10 years ago Actions #6

  • Status changed from Open to Closed

Applied in changeset r53551.


  • common.mk: test-sample was changed to test-basic.
    [Feature #11982][ruby-core:72823]
  • basictest/runner.rb: ditto. rename from tool/rubytest.rb.
  • basictest/test.rb: ditto. rename from sample/test.rb.
  • defs/gmake.mk: picked from r53540
  • sample/test.rb: backword compatibility for chkbuild.
Actions

Also available in: PDF Atom