Bug #12055: `NET::HTTPResponse` is not deflating responses with custom `Content-Range` header

• Status: Closed
• Assignee: naruse (Yui NARUSE)
• Target version: -
• ruby -v: 2.1.6, 2.2.4
• Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN, 2.3: UNKNOWN
• Tags: patch, lib

[ggcampinho (Glauber Campinho)]

The RFC 7233, section 4.2 describes the the possibility of using a custom Content-Range header and not only for bytes https://tools.ietf.org/html/rfc7233#section-4.2. Although, the NET::HTTPResponse considers that Content-Range present on the response during the inflating is in bytes unit.

This issue is caused by this line https://github.com/ruby/ruby/blob/trunk/lib/net/http/response.rb#L252. In the patch I changed it to check if the Content-Range unit is bytes and there is a test to reproduce the error.

[ggcampinho (Glauber Campinho)]

• File deleted (custom_content_range.patch)

[ggcampinho (Glauber Campinho)]

• File custom_content_range.patch custom_content_range.patch added

[ggcampinho (Glauber Campinho)]

Hi! Any thoughts here?

[ggcampinho (Glauber Campinho)]

?

[jeremyevans0 (Jeremy Evans)]

• Status changed from Open to Assigned
• Assignee set to naruse (Yui NARUSE)

[jeremyevans0 (Jeremy Evans)]

• Is duplicate of Bug #11450: HTTPHeader.content_range throws error on non-byte units added

[nobu (Nobuyoshi Nakada)]

• Description updated (diff)

• Status changed from Assigned to Closed

Applied in changeset git|63546bfc1581d4abec2a0d846106a1c0afc0efa9.

---

HTTPHeader.content_range throws error on non-byte units

• Added a nil check in Net::HTTPHeader#initialize_http_header for keys in the header that do not have any value
• Returning nil from the content_range method instead of raising an error when the unit in the content-range header is not bytes
• Modified initialize_http_header to match trunk

fix [Bug #11450]
fix https://github.com/ruby/ruby/pull/1018