Bug #12203: dumper.c static int yaml_emitter_dump_scalar two variables have the same value

• Status: Third Party's Issue
• Assignee: tenderlovemaking (Aaron Patterson)
• Target version: -
• Backport: 2.1: UNKNOWN, 2.2: UNKNOWN, 2.3: UNKNOWN

[fanantoxa (Anton Sivakov)]

static int
yaml_emitter_dump_scalar(
.....
int plain_implicit = (strcmp((char *)node->tag,
               YAML_DEFAULT_SCALAR_TAG) == 0);
int quoted_implicit = (strcmp((char *)node->tag,
                YAML_DEFAULT_SCALAR_TAG) == 0);

variables 'plain_implicit' and 'quoted_implicit' have the same values. It possible wrong expression or this code can be optimized.

[shyouhei (Shyouhei Urabe)]

• Status changed from Open to Assigned
• Assignee set to tenderlovemaking (Aaron Patterson)

They are passed to a macro. I guess the author intentionally separated these two because merging them makes the code less intuitive. It seems OK to be optimized.

[fanantoxa (Anton Sivakov)]

shyouhei (Shyouhei Urabe) wrote:

They are passed to a macro. I guess the author intentionally separated these two because merging them makes the code less intuitive. It seems OK to be optimized.

Maybe reassign to someone else? Or at lease chen that this still here?

[nobu (Nobuyoshi Nakada)]

• Status changed from Assigned to Third Party's Issue

Please report it to the upstream, https://github.com/ruby/psych.