Bug #12279: cont.c: wrong _MSC_VER check

• Status: Closed
• Assignee: -
• Target version: -
• Backport: 2.1: DONTNEED, 2.2: DONTNEED, 2.3: DONE

[cremno (cremno phobia)]

2.3.0 and trunk are affected. I wonder why compiling with Visual C++ 6.0 is still supported.

diff --git a/cont.c b/cont.c
index 8ebd78f..729a025 100644
--- a/cont.c
+++ b/cont.c
@@ -657,7 +657,7 @@ fiber_initialize_machine_stack_context(rb_fiber_t *fib, size_t size)
     rb_thread_t *sth = &fib->cont.saved_thread;
 
 #ifdef _WIN32
-# if defined(_MSC_VER) && _MSC_VER <= 0x1200
+# if defined(_MSC_VER) && _MSC_VER <= 1200
 #   define CreateFiberEx(cs, stacksize, flags, entry, param) \
     CreateFiber((stacksize), (entry), (param))
 # endif

[nobu (Nobuyoshi Nakada)]

• Status changed from Open to Closed

Applied in changeset r54574.

---

cont.c: wrong _MSC_VER check

• cont.c (fiber_initialize_machine_stack_context): fix wrong
  _MSC_VER check, should be decimal but not hexadecimal.
  [ruby-core:74936] [Bug #12279]

[naruse (Yui NARUSE)]

• Backport changed from 2.1: DONTNEED, 2.2: DONTNEED, 2.3: REQUIRED to 2.1: DONTNEED, 2.2: DONTNEED, 2.3: DONE

ruby_2_3 r54634 merged revision(s) 54574.