Project

General

Profile

Actions

Bug #12539

closed

Comments and typos in the tool directory

Added by noahgibbs (Noah Gibbs) almost 6 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Target version:
-
ruby -v:
2.4.0dev (2016-07-01 trunk 55556) [x86_64-darwin15]
[ruby-core:76215]

Description

I've commented most of the tool directory scripts, and fixed typos in a few of the comments. Since I was looking through, it seemed like a good idea for future readers.

Patch attached.


Files

tool_comments.patch (10.4 KB) tool_comments.patch noahgibbs (Noah Gibbs), 07/01/2016 03:12 PM
Actions #1

Updated by Anonymous almost 6 years ago

  • Status changed from Open to Closed

Applied in changeset r55564.


tool: add descriptions and fix typos

  • tool/asm_parse.rb: add description
  • tool/change_maker.rb: ditto
  • tool/downloader.rb: ditto
  • tool/eval.rb: ditto
  • tool/expand-config.rb: ditto
  • tool/extlibs.rb: ditto
  • tool/fake.rb: ditto
  • tool/file2lastrev.rb: ditto
  • tool/gem-unpack.rb: ditto
  • tool/gen_dummy_probes.rb: ditto
  • tool/gen_ruby_tapset.rb: ditto
  • tool/generic_erb.rb: ditto
  • tool/id2token.rb: ditto
  • tool/ifchange: ditto
  • tool/insns2vm.rb: ditto
  • tool/instruction.rb: ditto
  • tool/jisx0208.rb: ditto
  • tool/merger.rb: ditto
  • tool/mkrunnable.rb: ditto
  • tool/node_name.rb: ditto
  • tool/parse.rb: ditto
  • tool/rbinstall.rb: ditto
  • tool/rbuninstall.rb: ditto
  • tool/rmdirs: ditto
  • tool/runruby.rb: ditto
  • tool/strip-rdoc.rb: ditto
  • tool/vcs.rb: ditto
  • tool/vtlh.rb: ditto
  • tool/ytab.sed: ditto
  • tool/enc-unicode.rb: fix typo
  • tool/mk_call_iseq_optimized.rb: ditto
  • tool/update-deps: ditto
    [ruby-core:76215] [Bug #12539]
    by Noah Gibbs

Updated by normalperson (Eric Wong) almost 6 years ago

wrote:

Bug #12539: Comments and typos in the tool directory
https://bugs.ruby-lang.org/issues/12539

Thanks, committed as r55564
(wrapped one long line tool/gen_dummy_probes.rb)

Updated by usa (Usaku NAKAMURA) almost 6 years ago

  • Backport changed from 2.1: UNKNOWN, 2.2: UNKNOWN, 2.3: UNKNOWN to 2.1: WONTFIX, 2.2: WONTFIX, 2.3: UNKNOWN

Updated by nagachika (Tomoyuki Chikanaga) almost 6 years ago

  • Backport changed from 2.1: WONTFIX, 2.2: WONTFIX, 2.3: UNKNOWN to 2.1: WONTFIX, 2.2: WONTFIX, 2.3: WONTFIX
Actions

Also available in: Atom PDF