Bug #12908: make-snapshot is broken

• Status: Closed
• Assignee: naruse (Yui NARUSE)
• Target version: -
• ruby -v: trunk
• Backport: 2.1: UNKNOWN, 2.2: UNKNOWN, 2.3: UNKNOWN

[vo.x (Vit Ondruch)]

Testing with r56663, the make-snapshot fails with message:

$ tool/make-snapshot -packages=xz tmp
/builddir/ruby/tool/vcs.rb:123:in `realpath': no implicit conversion of URI::HTTP into String (TypeError)
	from /builddir/ruby/tool/vcs.rb:123:in `initialize'
	from tool/make-snapshot:416:in `new'
	from tool/make-snapshot:416:in `<main>'

It does not work since r56638, although the error was different initially.

[vo.x (Vit Ondruch)]

• Assignee set to naruse (Yui NARUSE)

[vo.x (Vit Ondruch)]

• Subject changed from make-snapshot is broke to make-snapshot is broken

[vo.x (Vit Ondruch)]

• Related to Misc #12283: Obsolete ChangeLog and commit message in Git-style added

[vo.x (Vit Ondruch)]

It seems that this works:

tool/make-snapshot -packages=xz -srcdir=. tmp

i.e. the -srcdir=. makes a difference ...

[nobu (Nobuyoshi Nakada)]

• Status changed from Open to Closed

Applied in changeset r56668.

---

vcs.rb: fix srcdir in VCS::GIT

• tool/vcs.rb (VCS::GIT.cmd_args): add chdir option to arguments
  for IO.popen if srcdir is a local path. unless -srcdir command
  line option is given, srcdir is the default URL.
  [ruby-core:78036] [Bug #12908]

[vo.x (Vit Ondruch)]

Thx for the fix.