Project

General

Profile

Actions

Bug #12946

closed

net-http is breaking valid http headers like HTTP2-Settings

Added by chucke (Tiago Cardoso) over 7 years ago. Updated over 7 years ago.

Status:
Closed
Assignee:
-
Target version:
-
[ruby-core:78159]

Description

The Net::HTTPHeader can't process the HTTP2-Settings header, which is a valid header destined to pass base64-encoded settings to a soon-to-be-upgraded-to-http2 connection.

req=Net::HTTP::Get.new
req["Upgrade"] = "h2c"
req["HTTP2-Settings] = "base64encoded=="

req.to_hash #=> "... Http2-Settings => ..."

Although one could say that net-http doesn't support to-http2-upgraded connections and even doesn't provide access to the raw socket, it's still a valid HTTP1.1 header, and the headers current MO "force to downcase and store; capitalize on fetch" works against custom Upgrade headers.

As of now, net-http can't upgrade. I'd suggest an API for such things, in that after a successful Upgrade request (101 switch protocols), the http connection "gives up" the socket to something else.

I had to monkey-patch my way out of this to make my code work: https://github.com/TiagoCardoso1983/jaguar/blob/master/test/test_helper.rb#L16-L25 .

Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0Like0