Implement Set#include? with Hash#include?
Set#include? not call
Hash#include?? Currently it calls
The protocol of Set already use
diff --git a/lib/set.rb b/lib/set.rb index 43c388c..f3dbe2d 100644 --- a/lib/set.rb +++ b/lib/set.rb @@ -230,7 +230,7 @@ def flatten! # # See also Enumerable#include? def include?(o) - @hash[o] + @hash.include?(o) end alias member? include?
Updated by knu (Akinori MUSHA) over 2 years ago
It originally used Hash#include?, but changed to use Hash# to benefit from the optimized dispatch VM instruction for
 (opt_aref). ([Misc #10754])
Running a benchmark, I can observe that Hash# actually has an advantage over include? in performance (up to ~1.2x faster) but the "optimization" may only apply to CRuby. Do you think we should have a straightforward implementation for a library shared between Ruby implementations, or is it OK to leave this if I add a comment to explain why?
Updated by headius (Charles Nutter) over 1 year ago
I would prefer the straightforward implementation, but I have some bias.
In JRuby, the
 method generally is more expensive, because it might be
String# with a Regex, which needs to be able to set
$~, so we deoptimize some things when
 is being called.
What's good for MRI here is bad for JRuby :-)
I guess the real question here is whether it would matter if JRuby just used
Hash#include? in our version of the library. I think there might be some oddities around nil, but that already seems pretty odd in a Set.