Project

General

Profile

Bug #13125

MRI has too much Qtrue : Qfalse;

Added by shyouhei (Shyouhei Urabe) almost 3 years ago. Updated almost 3 years ago.

Status:
Open
Priority:
Normal
Assignee:
-
Target version:
-
[ruby-core:79066]

Description

% git grep -P 'Q(true|false|nil|undef)\s+:\s+Q(true|false|nil|undef)' | wc -l
211

Out of those 211 occurrences the most interesting lines include:

complex.c:#define f_boolcast(x) ((x) ? Qtrue : Qfalse)
math.c:#define f_boolcast(x) ((x) ? Qtrue : Qfalse)
range.c:#define RBOOL(v) ((v) ? Qtrue : Qfalse)
rational.c:#define f_boolcast(x) ((x) ? Qtrue : Qfalse)

I strongly believe that we need an orthodox way to do this.

History

Updated by shyouhei (Shyouhei Urabe) almost 3 years ago

We looked at this issue at yesterday's developer meeting. Nobody was against introducing a macro. No consensus over its name was made though.

  • RBOOL() seems like a member of RSTRING(), RARRAY() and family so not very good.
  • It is in fact a INT2FIX()'s family so I proposed BOOL2BOOL() but this sounds too strange.
  • What is needed is a "reverse" of RTEST() so RUNTEST() is proposed (I believe it was not serious).

Updated by rmosolgo (Robert Mosolgo) almost 3 years ago

"reverse" of RTEST()

How about ...

  • CTEST()
  • TEST2BOOL()
  • C2BOOL()

Hope those help brainstorm a bit :)

Updated by znz (Kazuhiro NISHIYAMA) almost 3 years ago

How about BOOL2RBOOL?

Updated by phluid61 (Matthew Kerwin) almost 3 years ago

Seem to me like VALUE2BOOL, except perhaps for the way it casts Qnil to Qtrue

Updated by nobu (Nobuyoshi Nakada) almost 3 years ago

Someone suggested RB_BOOL at the meeting.

Also available in: Atom PDF