Project

General

Profile

Actions

Bug #13387

closed

[PATCH]Add parenthesis to fix compile warning to string.c

Added by litmon (Fukuo Kadota) over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Target version:
-
[ruby-core:80471]

Description

When editing string.c and execute make run, below warnings showed.

$ make run
../ruby/string.c:6142:41: warning: '&&' within '||' [-Wlogical-op-parentheses]
  ...(flags&ONIGENC_CASE_ASCII_ONLY) && (enc==rb_utf8_encoding() || rb_enc_mbmaxlen(enc)==1)
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../ruby/string.c:6142:41: note: place parentheses around the '&&' expression to
      silence this warning
  ...(flags&ONIGENC_CASE_ASCII_ONLY) && (enc==rb_utf8_encoding() || rb_enc_mbmaxlen(enc)==1)
                                     ^
     (                                                                                      )
../ruby/string.c:6208:41: warning: '&&' within '||' [-Wlogical-op-parentheses]
  ...(flags&ONIGENC_CASE_ASCII_ONLY) && (enc==rb_utf8_encoding() || rb_enc_mbmaxlen(enc)==1)
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../ruby/string.c:6208:41: note: place parentheses around the '&&' expression to
      silence this warning
  ...(flags&ONIGENC_CASE_ASCII_ONLY) && (enc==rb_utf8_encoding() || rb_enc_mbmaxlen(enc)==1)
                                     ^
     (                                                                                      )

I fixed this warnings using note.
in Github:
https://github.com/ruby/ruby/pull/1570

Actions #1

Updated by sorah (Sorah Fukumori) over 5 years ago

  • Status changed from Open to Closed

Applied in changeset trunk|r58211.


string.c: Supress logical-op-parentheses warning

Actions #2

Updated by usa (Usaku NAKAMURA) over 5 years ago

  • Backport changed from 2.2: UNKNOWN, 2.3: UNKNOWN, 2.4: UNKNOWN to 2.2: DONTNEED, 2.3: DONTNEED, 2.4: REQUIRED

Updated by nagachika (Tomoyuki Chikanaga) over 5 years ago

  • Backport changed from 2.2: DONTNEED, 2.3: DONTNEED, 2.4: REQUIRED to 2.2: DONTNEED, 2.3: DONTNEED, 2.4: DONE

ruby_2_4 r58635 merged revision(s) 58211.

Actions

Also available in: Atom PDF