Project

General

Profile

Actions
Copy link

Bug #13387

closed

[PATCH]Add parenthesis to fix compile warning to string.c

Added by litmon (Fukuo Kadota) over 7 years ago. Updated over 7 years ago.

Status:
Closed
Assignee:
-
Target version:
-
ruby -v:
Backport:
2.2: DONTNEED, 2.3: DONTNEED, 2.4: DONE
[ruby-core:80471]

Description

When editing string.c and execute make run, below warnings showed.

$ make run
../ruby/string.c:6142:41: warning: '&&' within '||' [-Wlogical-op-parentheses]
  ...(flags&ONIGENC_CASE_ASCII_ONLY) && (enc==rb_utf8_encoding() || rb_enc_mbmaxlen(enc)==1)
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../ruby/string.c:6142:41: note: place parentheses around the '&&' expression to
      silence this warning
  ...(flags&ONIGENC_CASE_ASCII_ONLY) && (enc==rb_utf8_encoding() || rb_enc_mbmaxlen(enc)==1)
                                     ^
     (                                                                                      )
../ruby/string.c:6208:41: warning: '&&' within '||' [-Wlogical-op-parentheses]
  ...(flags&ONIGENC_CASE_ASCII_ONLY) && (enc==rb_utf8_encoding() || rb_enc_mbmaxlen(enc)==1)
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../ruby/string.c:6208:41: note: place parentheses around the '&&' expression to
      silence this warning
  ...(flags&ONIGENC_CASE_ASCII_ONLY) && (enc==rb_utf8_encoding() || rb_enc_mbmaxlen(enc)==1)
                                     ^
     (                                                                                      )

I fixed this warnings using note.
in Github:
https://github.com/ruby/ruby/pull/1570

Actions
Copy link

Also available in: Atom PDF

Like0
Like0Like0Like0