Bug #13427: gemspec might be treat as binary - probably bug?

• Status: Closed
• Assignee: hsbt (Hiroshi SHIBATA)
• Target version: -
• Backport: 2.3: DONTNEED, 2.4: DONTNEED, 2.5: DONTNEED

[Hanmac (Hans Mackowiak)]

while getting latest ruby sources i noticed that json.gemspec is treated as binary by git.

and while looking why that is, i noticed that the gemspec for some reason "\0" is inside the file,
which causes text programms to think its a binary file instead of a text file.

to checkout why that happens, it seems that rubygems itself did add the "\0" into the file which seems to be wrong.
there is a open ticket in the repo of rubygems opend in "14 Apr 2014" but it is unanswerd since months.

also i see that rubygems also did many ".freeze" into the files while "# frozen_string_literal: true" should probably used.
that might not be done jet because ruby 2.2 is still in "security maintenance phase"?

links:

https://github.com/rubygems/rubygems/issues/883
https://github.com/flori/json/issues/310 (unanswerd)

[vo.x (Vit Ondruch)]

Hanmac (Hans Mackowiak) wrote:

there is a open ticket in the repo of rubygems opend in "14 Apr 2014" but it is unanswerd since months.

True ...

also i see that rubygems also did many ".freeze" into the files while "# frozen_string_literal: true" should probably used.
that might not be done jet because ruby 2.2 is still in "security maintenance phase"?

RubyGems still supports even Ruby 1.8.7 if I am not mistaken:

https://github.com/rubygems/rubygems/blob/master/.travis.yml

[nobu (Nobuyoshi Nakada)]

• Status changed from Open to Third Party's Issue

[hsbt (Hiroshi SHIBATA)]

• Status changed from Third Party's Issue to Closed
• Assignee set to hsbt (Hiroshi SHIBATA)
• Backport changed from 2.2: UNKNOWN, 2.3: UNKNOWN, 2.4: UNKNOWN to 2.3: DONTNEED, 2.4: DONTNEED, 2.5: DONTNEED

Closed at r65461