Project

General

Profile

Bug #13428

rbinstall should not use Spec#files anymore

Added by vo.x (Vit Ondruch) almost 3 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
Normal
Target version:
-
ruby -v:
ruby 2.5.0dev (2017-04-11 trunk 58327) [x86_64-linux]
[ruby-core:80667]

Description

I'd like to clarify this line 1.

Just two days ago, it was removed by my PR 2 in r58317 and now it is back in r58327. Is this just mistake?

If the gem is listed in gems/bundled_gems, the gem is downloaded from RubyGems, expanded and the .gemspec 3 is containing list of the files originally shipped in the .gem package (this is actually wrong, since the gem might ship its own .gemspec file and this one rewrites the original one and later the installation contains this non-original file, but this is different story).

In case of default gems, neither here is the file list needed since my PR 4 merged in r58317.

So I am wondering under what other circumstances is the line 1 needed? For what purpose it returned to the codebase?


Related issues

Related to Ruby master - Bug #13423: error in etc.gemspecClosedhsbt (Hiroshi SHIBATA)Actions
#1

Updated by vo.x (Vit Ondruch) almost 3 years ago

  • Related to Bug #13423: error in etc.gemspec added

Updated by nobu (Nobuyoshi Nakada) almost 3 years ago

  • Status changed from Open to Rejected

It's used only for default gems, spec.files are for separated gem releases, but just garbage there.

Updated by vo.x (Vit Ondruch) almost 3 years ago

But the spec.files is not used anywhere, since the .gemspec is installed via gemspec.to_ruby_for_cache, which does not list the files. Therefore what is its content doesn't really matter.

Updated by nobu (Nobuyoshi Nakada) almost 3 years ago

  • Status changed from Rejected to Open

Nice point.

#5

Updated by nobu (Nobuyoshi Nakada) almost 3 years ago

  • Status changed from Open to Closed

Applied in changeset trunk|r58345.


rbinstall.rb: no file list for default gems

  • tool/rbinstall.rb (default-gems): no file list is used now. all files should be installed as standard libraries. [ruby-core:80667] [Bug #13428]

Also available in: Atom PDF