Refined methods ignore visibility of inherited methods
This bug was pointed out by al2o3-cr on the #ruby IRC channel on freenode. The following code sleeps for 3 seconds, even though
String#sleep is a private method.
module Test refine String do def sleep; end end end puts "start" "".sleep 3 puts "end"
This happens because
vm_call_method_each_type, when running a method of type
vm_call_zsuper to call inherited methods, which does not check the visibility of the method and directly executes it. I attached a patch which changes this code path and uses
vm_call_method to trigger the code that honors method visibilities. I have not played extensively with this patch, but it at least does not seem to break any existing unit tests.
Updated by nobu (Nobuyoshi Nakada) about 3 years ago
- Status changed from Open to Closed